fix: gRPC metadata header casing and invocation_metadata() call#676
Conversation
…quest extension overrides in client and server.
Summary of ChangesHello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two critical issues in the gRPC support: ensuring that extension header keys are always lowercase for compliance with gRPC standards and correcting the invocation of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR addresses two issues in the gRPC support: standardizing extension headers to lowercase and correcting the invocation of servicer_context.invocation_metadata as a method. The changes involve modifying the client and server-side code to ensure consistency in header casing and proper method invocation, along with updating the corresponding tests to reflect these changes.
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
… `context.invocation_metadata()` return
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
grpc.aio.ServicerContext to use the correct syntax[`Metadata` is a `Collection`](https://grpc.github.io/grpc/python/_modules/grpc/aio/_metadata.html) so iterating over key-value tuples is possible, there are existing tests in `test_grpc_handler.py`. Re #676
🤖 I have created a release *beep* *boop* --- ## [0.3.23](v0.3.22...v0.3.23) (2026-02-13) ### Features * add async context manager support to BaseClient ([#688](#688)) ([ae9dc88](ae9dc88)) * add async context manager support to ClientTransport ([#682](#682)) ([2e45c0d](2e45c0d)) * support async card modifiers ([#654](#654)) ([a802500](a802500)) * support disabling OTel instrumentation via env var ([#611](#611)) ([72216b9](72216b9)) ### Bug Fixes * do not crash on SSE comment line ([#636](#636)) ([3dcb847](3dcb847)) * gRPC metadata header casing and invocation_metadata() call ([#676](#676)) ([390b763](390b763)) * Improve error handling for Timeout exceptions on REST and JSON-RPC clients ([#690](#690)) ([2acd838](2acd838)) * map rejected task state in proto converters ([#668](#668)) ([957e92b](957e92b)), closes [#625](#625) * **server:** fix deadlocks on agent execution failure in non-streaming ([#614](#614)) ([d3c973f](d3c973f)) ### Documentation * explicitly mention supported spec version and transports in readme ([#681](#681)) ([c91d4fb](c91d4fb)), closes [#677](#677) * Update README to include Code Wiki badge ([2698cc0](2698cc0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This PR fixes two issues related to the grpc support:
servicer_context.invocation_metadataas a method instead of as a propertyFor each of these issues was respectively opened a community PR (#635 , #673). To speed up the integration of these changes, this new PR has been created to integrate both changes at the same time.
Fixes #656