-
Notifications
You must be signed in to change notification settings - Fork 351
fix: Standardize gRPC extension header to lowercase and update invocation metadata from grpc.aio.ServicerContext to use the correct syntax
#676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…quest extension overrides in client and server.
Summary of ChangesHello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two critical issues in the gRPC support: ensuring that extension header keys are always lowercase for compliance with gRPC standards and correcting the invocation of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR addresses two issues in the gRPC support: standardizing extension headers to lowercase and correcting the invocation of servicer_context.invocation_metadata as a method. The changes involve modifying the client and server-side code to ensure consistency in header casing and proper method invocation, along with updating the corresponding tests to reflect these changes.
| extensions_to_use = ( | ||
| extensions if extensions is not None else self.extensions | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| extensions_to_use = ( | |
| extensions if extensions is not None else self.extensions | |
| ) | |
| extensions_to_use = extensions or self.extensions |
This should handle the same cases, unless you want [] to be handled differently?
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
This PR fixes two issues related to the grpc support:
servicer_context.invocation_metadataas a method instead of as a propertyFor each of these issues was respectively opened a community PR (#635 , #673). To speed up the integration of these changes, this new PR has been created to integrate both changes at the same time.