Skip to content

refactor: simplify metadata reading in grpc_handler.py #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ishymko merged 2 commits into from
Feb 12, 2026
Merged

refactor: simplify metadata reading in grpc_handler.py #685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b5db09
refactor: simplify metadata reading in grpc_handler.py
ishymko Feb 12, 2026
1d3f8be
Merge branch 'main' into ishymko/metadata-refactor
ishymko Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions src/a2a/server/request_handlers/grpc_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,12 @@
import logging

from abc import ABC, abstractmethod
from collections.abc import AsyncIterable, Awaitable, Sequence
from typing import TYPE_CHECKING
from collections.abc import AsyncIterable, Awaitable


try:
import grpc
import grpc.aio

if TYPE_CHECKING:
from grpc.aio._typing import MetadataType
from grpc.aio import Metadata
except ImportError as e:
raise ImportError(
'GrpcHandler requires grpcio and grpcio-tools to be installed. '
Expand Down Expand Up @@ -56,14 +51,16 @@ def build(self, context: grpc.aio.ServicerContext) -> ServerCallContext:
def _get_metadata_value(
context: grpc.aio.ServicerContext, key: str
) -> list[str]:
md: MetadataType | None = context.invocation_metadata()
raw_values: list[str | bytes] = []
md = context.invocation_metadata()
if md is None:
return []

lower_key = key.lower()
if isinstance(md, Metadata):
raw_values = md.get_all(lower_key)
elif isinstance(md, Sequence):
raw_values = [e for (k, e) in md if k.lower() == lower_key]
return [e if isinstance(e, str) else e.decode('utf-8') for e in raw_values]
return [
e if isinstance(e, str) else e.decode('utf-8')
for k, e in md
if k.lower() == lower_key
]


class DefaultCallContextBuilder(CallContextBuilder):
Expand Down
Loading