Repository navigation
fix(web_core): restore listStyle to v0.9 basic catalog ListApi schema - #3956
Merged
gspencergoog merged 2 commits intoNov 5, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request restores the 'listStyle' property to the v0.9 basic catalog 'ListApi' schema. The property is defined as an optional enum with values 'ordered', 'unordered', and 'none'. The changes update the JSON schema, the TypeScript schema definition, and the validation tests to ensure correct parsing and validation of the property. I have no feedback to provide.
gspencergoog
force-pushed
the
fix/v0-9-list-style-schema
branch
from
November 3, 2026 21:33
1902037 to
57a3803
Compare
gspencergoog
force-pushed
the
fix/v0-9-list-style-schema
branch
from
November 3, 2026 21:39
57a3803 to
f6c414b
Compare
josemontespg
approved these changes
Nov 3, 2026
1 task done
Resolve CHANGELOG conflicts in dart/a2ui_core, python/a2ui_core, and typescript/core/web_core by keeping both the listStyle entry and the entries added on main. The Dart entry stays under Unreleased, above the new 0.5.0 section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the
listStyleproperty ('ordered' | 'unordered' | 'none') to theListcomponent in the A2UI v0.9 basic catalog specification (specification/v0_9/catalogs/basic/catalog.json) and regenerates the v0.9 basic catalog APIs (typescript/core/web_core/src/v0_9/basic_catalog/components/basic_components.ts).Details
listStyle(string, enum:['ordered', 'unordered', 'none'], description: "The style of the list (ordered, unordered, or none).") toListinspecification/v0_9/catalogs/basic/catalog.json.basic_components.tsviagenerate-catalog.mjs, addinglistStyleas an optional enum onListApi.schema.conformance/test_data/validation_schema/test_v09_basic_validation_schema.jsonto includelistStylein the golden validation schema forList.List.test.tsverifying thatListApi.schema.parsevalidateslistStyle('none','ordered','unordered'), rejects invalid values, and validates list components usingPayloadValidator.## Unreleasedintypescript/core/web_core/CHANGELOG.md.Testing
node dist/src/universal/basic_catalog/components/List.test.js(8/8 passing)node dist/src/v0_9/test/verify-schema.test.js(3/3 passing)node tests/conformance/conformance_test.mjs(726/726 passing, 0 failures)corepack yarn workspace @a2ui/web_core build