fix: use pulls.listFiles API for PR changed files - #76
Merged
Conversation
The compareCommitsWithBasehead API can return 404 for PRs, likely due to URL encoding of branch names containing slashes (e.g. fix/something becomes fix%2Fsomething in the API path). Switch to pulls.listFiles for PR events, which uses the PR number instead of branch names and is the canonical API for getting PR changed files. Keep compareCommitsWithBasehead as fallback for push events. Also wrap getChangedFiles in try-catch in main.ts so the coverage report still posts even if changed file detection fails (just without diff coverage). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests Report 📄Tests Success ✅JUnit Details
Coverage Details (99% >= 80%) ✅Diff Cover Details
|
||||||||||||||||||||||||||||||||||
…handling - Test compareCommitsWithBasehead path (push events without prNumber) - Test pagination for compareCommitsWithBasehead - Test undefined files response in compareCommitsWithBasehead - Test empty refs returns empty result - Test getChangedFiles failure in main.ts logs warning and continues Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulls.listFilesAPI for PR events instead ofcompareCommitsWithBasehead— avoids 404 errors caused by URL encoding of branch names with/(e.g.fix/something→fix%2Fsomething)compareCommitsWithBaseheadas fallback for push events onlygetChangedFilesin try-catch so coverage report still posts even if changed file detection failsTest Plan
pulls.listFilesfor PR event tests🤖 Generated with Claude Code