fix: support variable-length abbreviated SHAs in blame matching - #77
Merged
Conversation
git log --format=%h produces abbreviated hashes whose length depends on core.abbrev and repo size (7, 8, 9+ chars). parseBlameForCommits was hardcoded to truncate blame SHAs to 7 chars, causing mismatches when git produced longer abbreviations — resulting in "No coverage details to present". Now dynamically determines the abbreviation length from the commit set instead of hardcoding 7. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests Report 📄Tests Success ✅JUnit Details
Coverage Details (100% >= 80%) ✅Diff Cover Details
|
||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseBlameForCommitswas hardcoded to truncate blame SHAs to 7 chars, butgit log --format=%hproduces variable-length hashes (7, 8, 9+ chars depending oncore.abbrev/ repo size)Test Plan
test: matches 9-char abbreviated SHA from git logtest: matches 8-char abbreviated SHAtest: does not false-match when abbrev length differstest: handles empty commit set gracefully🤖 Generated with Claude Code