Fix VS Code Marketplace README links#1105
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe VS Code README now links directly to the GitHub LSP server documentation, removes standalone Marketplace links, and adds Vera website and repository links while retaining the TextMate bundle reference. ChangesVS Code README updates
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 96 96
Lines 32708 32708
Branches 456 456
=======================================
Hits 30654 30654
Misses 2041 2041
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Review — complete and correct, ready to merge (README-only)Codex's diagnosis is right: the VS Code Marketplace does not support relative links in READMEs and rejects them, and this README had two relative Completeness audit (the thing that matters on a third attempt)I enumerated every link/image target in the final README, not just the diff:
No relative links, no Removing the two RiskREADME-only; the packaged bundle, dependencies, and manifest are unchanged, so this can't regress the extension itself. Caveat (same as before, and worth stating on attempt three)"Suspicious content" is an opaque verdict — the re-upload is the only real confirmation. Relative links are a documented Marketplace rejection cause, so this is a strong, well-founded fix. But if it still rejects after this, I'd stop guessing and use the "contact support" path the rejection message offers to get the specific trigger, rather than iterate blind. Good to merge and re-submit. |
Summary
Why
vscerewrites repository-relative links while packaging. Because the extension lives below the repository root, the two../../LSP_SERVER.mdlinks became malformedHEAD/../../URLs in the packaged README and returned HTTP 404. The README also linked to the extension's Marketplace page before that page existed, producing two more 404s.This removes known-bad metadata from the VSIX before retrying the Marketplace upload. Broken ordinary links are not documented by Microsoft as a definitive cause of the opaque "suspicious content" rejection, so this is a focused corrective step rather than a claim that the scanner's root cause is proven.
Validation
npm cinpm run checknpm run package:listnpm run package -- --out /tmp/vera-language-0.2.0-readme-fix.vsixextension/readme.mdinside the resulting VSIXnode_modulesSummary by CodeRabbit