Skip to content

chore: review codebase for missing CSS variables and accessibility gaps #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronedev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: review codebase for missing CSS variables and accessibility gaps #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"userStyle": {
"namespace": "github.com/aaronedev/violet-void-theme",
"version": "20260323.12.47"
"version": "20260324.21.26"
},
"scripts": {
"build": "node scripts/build.js",
Expand Down
14 changes: 14 additions & 0 deletions test_review.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Review the recent commits and current state of this ArchWiki Stylus theme repository. Focus on:
1. Missing CSS variables or broken selectors in src/components/
2. Accessibility issues
3. Mobile responsiveness gaps.
Return a concise list of the top 3 most important issues with specific file paths.

Issues found:
1. **Missing CSS Variables in Headings**: In `src/components/headings.styl`, several CSS custom properties (`--text-color`, `--border-color`, `--text-color-muted`) are used without fallbacks and without being defined in the `:root` scope of that file or `base.styl`.
2. **Missing CSS Variables in Modern CSS**: In `src/components/modern-css.styl`, `var(--accent)` is used without a fallback, despite `--accent` not being defined in the component or globally.
3. **Accessibility / Experimental Selectors**: In `src/components/headings.styl`, the `:heading` selector is used which is non-standard and not well supported, and there's no fallback for standard `h1, h2, h3, h4, h5, h6` elements.

These are specific missing variable issues, broken selectors (due to experimental syntax without fallback) that are explicitly causing issues.

I'll list these as the top 3 issues with specific file paths.