deprecate asdf.open(copy_arrays=True) in favor of asdf.open(memmap=False)

[zacharyburnett]

deprecation for asdf>=4.0

[lgarrison]

Thank you! Does this imply a higher minimum asdf version? Right now we're at >=2.8.

[zacharyburnett]

Thank you! Does this imply a higher minimum asdf version? Right now we're at >=2.8.

ah! yes, memmap was introduced asdf>=3.1.0. I can rework this to dynamically check the asdf version, if that's desirable (if you have users using asdf<3.1.0) or we can up the minimum version

[braingram]

Also FYI memmap will switch it's default to False in asdf 4.0.0 so it might not be necessary to provide it for asdf >= 4.0.0.dev since all the uses I see here are memmap=False.

xref: asdf-format/asdf#1801

[zacharyburnett]

Also FYI memmap will switch it's default to False in asdf 4.0.0 so it might not be necessary to provide it for asdf >= 4.0.0.dev since all the uses I see here are memmap=False.

there is one usage of memmap=True that I missed: #157 (comment)

[lgarrison]

I think setting the minimum to asdf>=3.1.0 would be fine.

[lgarrison]

Thanks @zacharyburnett and @braingram!