Skip to content

demo3: simplify #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

demo3: simplify #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e24bdfa
demo3: simplify
larshp May 25, 2025
daf0032
Merge branch 'main' into hvam/demo32505
larshp Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions src/demo003/zdemo_excel3.prog.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ CONSTANTS: c_airlines TYPE string VALUE 'Airlines'.
CONSTANTS: gc_save_file_name TYPE string VALUE '03_iTab.xlsx'.
INCLUDE zdemo_excel_outputopt_incl.

PARAMETERS: p_empty TYPE flag.
PARAMETERS: p_checkr NO-DISPLAY TYPE abap_bool.

START-OF-SELECTION.
" Creates active sheet
Expand All @@ -46,13 +44,7 @@ START-OF-SELECTION.

DATA lt_test TYPE ty_sflight_lines.

IF p_empty <> abap_true.
IF p_checkr = abap_true.
PERFORM load_fixed_data_for_checker CHANGING lt_test.
ELSE.
SELECT * FROM sflight INTO TABLE lt_test. "#EC CI_NOWHERE
ENDIF.
ENDIF.
PERFORM load_fixed_data_for_checker CHANGING lt_test.

ls_table_settings-table_style = zcl_excel_table=>builtinstyle_medium2.
ls_table_settings-show_row_stripes = abap_true.
Expand All @@ -61,10 +53,8 @@ START-OF-SELECTION.
lo_worksheet->bind_table( ip_table = lt_test
is_table_settings = ls_table_settings ).

IF p_checkr = abap_true.
PERFORM set_column_headers USING lo_worksheet
'Airline;Flight Number;Date;Airfare;Airline Currency;Plane Type;Max. capacity econ.;Occupied econ.;Total;Max. capacity bus.;Occupied bus.;Max. capacity 1st;Occupied 1st'.
ENDIF.
PERFORM set_column_headers USING lo_worksheet
'Airline;Flight Number;Date;Airfare;Airline Currency;Plane Type;Max. capacity econ.;Occupied econ.;Total;Max. capacity bus.;Occupied bus.;Max. capacity 1st;Occupied 1st'.

lo_worksheet->freeze_panes( ip_num_columns = 1 ip_num_rows = 1 ). "freeze column headers when scrolling
IF lines( lt_test ) >= 1.
Expand All @@ -81,11 +71,9 @@ START-OF-SELECTION.
lv_title = 'Data Validation'.
lo_worksheet->set_title( lv_title ).
lo_worksheet->set_cell( ip_row = 1 ip_column = 'A' ip_value = c_airlines ).
IF p_checkr = abap_true.
PERFORM load_scarr_data_for_checker CHANGING lt_carr.
ELSE.
SELECT * FROM scarr INTO TABLE lt_carr. "#EC CI_NOWHERE
ENDIF.

PERFORM load_scarr_data_for_checker CHANGING lt_carr.

LOOP AT lt_carr ASSIGNING <carr>.
lo_worksheet->set_cell( ip_row = row ip_column = 'A' ip_value = <carr>-carrid ).
row = row + 1.
Expand Down