Ed25519 asymmetric signing for packs, evidence, certificates (closes #1)#5
Merged
Conversation
…tificates Adds asymmetric signing alongside the existing HMAC scheme. volo_core.asymmetric provides Ed25519 keygen/sign/verify, lazily importing cryptography so the OSS core stays lean (available via the volo-core[crypto] extra). Packs, compliance evidence packs, and Volo Certified certificates gain sign_*_ed25519 helpers: the issuer signs with a private key and anyone verifies with only the public key, holding no secret that could forge new signatures — what a public credential wants. The signature envelope was already algorithm-tagged, so verification selects HMAC vs Ed25519 by tag and a keyring can mix symmetric and asymmetric publishers. The HMAC path is unchanged and stays the default. 11 tests (core primitive + per-artifact roundtrip/tamper/wrong-key). Closes #1.
🛫 Volo reliability — ❌ NO-SHIPReplayed 7 adversarial scenarios against the agent (threshold ≥ 0.90).
Cost — replayed deterministically at $0 (no live API calls). baseline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
Adds asymmetric (Ed25519) signing alongside the existing HMAC-SHA256 scheme for packs (M25), compliance evidence (M29), and Volo Certified certificates (M33).
Why
HMAC is a symmetric shared secret — fine inside one trust domain, but a public credential (a signed certificate or evidence pack) wants asymmetric signing: the issuer signs with a private key and anyone verifies with the public key, holding no secret that could forge new signatures.
What
volo_core.asymmetric— Ed25519generate_keypair/sign_ed25519/verify_ed25519. Lazily importscryptography(clear error if absent), so the OSS core stays lean; exposed as thevolo-core[crypto]extra and pulled by the signing packages.sign_pack_ed25519/sign_evidence_ed25519/sign_certificate_ed25519. The signature envelope was already algorithm-tagged (ADR-0028 anticipated this), soverify_*selects HMAC vs Ed25519 by tag and a keyring can mix symmetric + asymmetric publishers.Tests
11 new: the core primitive (keygen/sign/verify, tamper, wrong-key, garbage-signature), plus per-artifact roundtrip + wrong-key + tamper for certificates, packs (incl. a mixed HMAC+Ed25519 keyring), and evidence. Full suite 539 passed, mypy clean (126 files), ruff clean.
Refs ADR-0028, ADR-0037.