Make Checkout / Quick Checkout / Push for Review work without configuring git auth separately - #15
Open
albin-paul-saju wants to merge 7 commits into
Open
Make Checkout / Quick Checkout / Push for Review work without configuring git auth separately#15albin-paul-saju wants to merge 7 commits into
albin-paul-saju wants to merge 7 commits into
Conversation
albin-paul-saju
changed the title
albin-paul-saju
force-pushed
the
fix-invalid-change-id-bug
branch
from
April 27, 2026 12:17
ecbc621 to
6486b06
Compare
albin-paul-saju
force-pushed
the
fix-quickcheckout-password-issue
branch
from
April 27, 2026 12:24
555cb30 to
139a4aa
Compare
albin-paul-saju
force-pushed
the
fix-quickcheckout-password-issue
branch
from
April 28, 2026 07:26
139a4aa to
95d4fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make Checkout, Quick Checkout, and Push for Review use the credentials already entered via "Gerrit: Enter credentials". No separate git credential helper.
Why
Those credentials live in VS Code SecretStorage and are only used for Gerrit's REST API. When the extension shells out (e.g.
git fetch origin refs/changes/35/328435/5),gitlooks them up from its own places (credential.helper,~/.netrc, SSH) and, finding nothing on a stock machine, fails non-interactively with:REST shows "Gerrit connection successful!" while every checkout/push silently breaks - the root cause of the "Quick checkout asks for password" report.
How
Per-invocation
GIT_ASKPASSshim (src/lib/git/gerritAskpass.ts) that injects the stored Gerrit creds into the singlegitchild process the extension is about to spawn - and nothing else. No global state, no secrets on disk.