-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add environment to github pages workflow #664
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes update GitHub Actions workflows by adding an environment configuration to the Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions
participant Job as deploy-storybook Job
participant Step as Deployment Step
participant Env as GitHub Pages Environment
GH->>Job: Trigger workflow
Job->>Step: Execute deployment
Step-->>Job: Return page URL
Job->>Env: Configure environment with page URL
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
7e3471b
to
d9f1d35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release.yml
(1 hunks).github/workflows/review.yml
(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/review.yml
19-19: property "deployment" is not defined in object type {deploy: {conclusion: string; outcome: string; outputs: {page_url: string}}}
(expression)
.github/workflows/release.yml
38-38: property "deployment" is not defined in object type {deploy: {conclusion: string; outcome: string; outputs: {page_url: string}}}
(expression)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run linters and tests
🔇 Additional comments (2)
.github/workflows/review.yml (1)
1-16
: Approval: Workflow Structure and PermissionsThe overall workflow structure and permission settings (e.g., contents, pages, id-token) are clear and consistent. This enhances the deployment process for review builds.
.github/workflows/release.yml (1)
1-35
: Approval: Release Workflow StructureThe rest of the release workflow is well-structured and the added environment configuration is consistent with best practices for GitHub Actions. The inclusion of the environment section enhances the deployment tracking for GitHub Pages.
🧰 Tools
🪛 actionlint (1.7.4)
18-18: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
d9f1d35
to
20d15ee
Compare
Review env workflow has gone belly up, citing the need for an
environment
variable in the GH workflow. I've added that here, and also altered the environment permissions to allow deployment from any branch to this env, but to require an approval from a member of the web team.Summary by CodeRabbit