Repository navigation
Unify product Clone, "Save as new" and admin "Save as new" into a single clone feature #603
Description
Following:
A product can be duplicated in 3 different ways, each with its own implementation:
- Clone:
ProductCloneForm, used by the UI clone view and the APIcloneaction - Save as new:
ProductForm, on the product edit page - Admin:
ProductAdmin.save_model, the "Save as new" button in the admin
They do not copy the same data, so the result depends on which one is used:
| Data | Clone | Save as new | Admin |
|---|---|---|---|
| Components, Packages, triage rulesets | Yes | Yes | Yes |
| Dependencies | Yes | No | No |
| Codebase resources | Yes | Yes | No |
Codebase resources deployment links (deployed_to) |
No | No | No |
| Vulnerability analyses | No | No | No |
| Object permissions | Optional | No | No |
| Triage re-evaluation | Yes | No | Yes |
The goal of a clone is to get the exact same product under a new version, except for the data unchecked in the clone options.
Proposed solution
- Keep Clone as the single way to duplicate a product, since the UI and the API already share it and it has the most complete behavior.
- Remove "Save as new" from the product edit form and from the product admin.
- Add the missing data to Clone: vulnerability analyses and codebase resources deployment links.
Activity
Fix aboutcode-org#603 unify product cloning