-
-
Notifications
You must be signed in to change notification settings - Fork 40
Migrate pypi pipeline to MineCodeBasePipeline #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
47ca035 to
51c8845
Compare
Reference: #778 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
51c8845 to
2e111ff
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
2e111ff to
ebf0c79
Compare
keshav-space
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AyanSinhaMahapatra, LGTM!
|
|
||
|
|
||
| def update_checkpoints_in_github(checkpoint, cloned_repo, path, logger): | ||
| def update_checkpoints_in_github(checkpoint, cloned_repo, path, logger=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logger is always required while calling commit_and_push_changes. Also this https://github.com/aboutcode-org/scancode.io/blob/06bc5d56dd28509bf11694f14dea7f45c2b83684/scanpipe/pipes/federatedcode.py#L292 is a bug.
| def update_checkpoints_in_github(checkpoint, cloned_repo, path, logger=None): | |
| def update_checkpoints_in_github(checkpoint, cloned_repo, path, logger): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This forces the use of logger throughout all the functions, which is not what we have elsewhere in SCIO, logging is turned on optionally and anything which is a error should be added as an error and not just handled as a log entry. And logging should be optional IMHO as a debug method, or to log progress.
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
6ffe662 to
8636aa0
Compare
|
We have pypi packageURLs being published now: https://github.com/orgs/aboutcode-data/repositories?q=pypi |
Reference: #778
Repositiories: https://github.com/orgs/aboutcode-data/repositories?q=pypi