Skip to content

Conversation

@AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Dec 9, 2025

Reference: #778
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AyanSinhaMahapatra, LGTM!



def update_checkpoints_in_github(checkpoint, cloned_repo, path, logger):
def update_checkpoints_in_github(checkpoint, cloned_repo, path, logger=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger is always required while calling commit_and_push_changes. Also this https://github.com/aboutcode-org/scancode.io/blob/06bc5d56dd28509bf11694f14dea7f45c2b83684/scanpipe/pipes/federatedcode.py#L292 is a bug.

Suggested change
def update_checkpoints_in_github(checkpoint, cloned_repo, path, logger=None):
def update_checkpoints_in_github(checkpoint, cloned_repo, path, logger):

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces the use of logger throughout all the functions, which is not what we have elsewhere in SCIO, logging is turned on optionally and anything which is a error should be added as an error and not just handled as a log entry. And logging should be optional IMHO as a debug method, or to log progress.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

We have pypi packageURLs being published now: https://github.com/orgs/aboutcode-data/repositories?q=pypi

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit de2cb7f into main Dec 10, 2025
1 of 2 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the minecode-pipeline-pypi branch December 10, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants