Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commoncode to v32.2.0 and pin bs4 #4149

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

AyanSinhaMahapatra
Copy link
Member

There was an issue in copyright scan and other places which was caused by a breaking change in bs4, which is fixed in commoncode with https://github.com/aboutcode-org/commoncode/releases/tag/v32.2.0

Reference: #4129
Reference: aboutcode-org/commoncode#79

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

There was an issue in copyright scan and other places which was
caused by a breaking change in bs4, which is fixed in commoncode
with https://github.com/aboutcode-org/commoncode/releases/tag/v32.2.0

Reference: #4129
Reference: aboutcode-org/commoncode#79
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit a7999a2 into develop Mar 6, 2025
38 of 40 checks passed
('sha1', None),
('md5', None),
('sha256', None),
('sha1', 0),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big change. What happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants