Add 8/16-bit integer support to SimpleAtoi #1762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current check fails for narrow types (e.g. uint16_t) because of integer promotion. This change fixes the check for more types.
|
Hi @derekmauro, I wanted to check in about this change. Is there any intent to merge it? Or is this feature on ice until somebody works on it internally? Thanks in advance. |
|
Just by chance someone started working on it this week. There is a fair chance it will happen next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
SimpleAtoimore ergonomic for tasks like parsing port numbers. These changes were mostly trivial copies of existing code paths. Two spots worth looking more closely at are:kIsSigned) which didn't work properly for these new narrower types, and has been updated.kUse64BitvskIntTypeSize).A bit of previous discussion was here. Even if these changes aren't merged via this PR, I'd love for this to expedite the process of getting them made internally.