vrrp: handle a reload with no more startup_delay #2559
Merged
+15
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the vrrp_startup_delay time, if keepalived is reloaded with no more startup_delay, the startup_delay is never timed out and all received adverts is discarded. The commit causes the startup_delay timer to be reinstated after a reload with no more startup_delay if the timer has not yet expired. Fixes: 58483b2 ("vrrp: Handle a reload before vrrp_delayed_start has expired") Signed-off-by: Louis Scalbert <[email protected]>
|
Please review this |
|
Thank you for the merge @pqarmitage I will address your remark on the other pull-request soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the vrrp_startup_delay time, if keepalived is reloaded with no more startup_delay, the startup_delay is never timed out and all received adverts is discarded.
The commit causes the startup_delay timer to be reinstated after a reload with no more startup_delay if the timer has not yet expired.
Fixes: 58483b2 ("vrrp: Handle a reload before vrrp_delayed_start has expired")