Skip to content

Mburton/sc log #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Mburton/sc log #28

wants to merge 17 commits into from

Conversation

markfoodyburton
Copy link
Contributor

No description provided.

eyck and others added 14 commits December 2, 2024 10:37
@eyck @markfoodyburton
factor out report backend implementation into separate header
fe8b52c 
report.h contains only the macros for simplified use of the SC report infrastructure. logger.h now contains the declaration of a custom lSC logging backend. report.cpp still needs to be refactored.
@eyck @markfoodyburton
changes messages in smoke_logger
07cb8d6
@eyck @markfoodyburton
factors logger function into separate source
c0cda73
@eyck @markfoodyburton
applies clang-format
4e70605
@markfoodyburton
Fix for upstream install on mac RPATH issue
b5985c0 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
Split the CCI mechanism from the rest of remote.h
59f3377 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
Maintain #include interface for ease of use
8a7689f 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
Split CCI fixes
8c0d292 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
update dependencies and cleanup
62601be 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
Rename SCP_LOGGER to SCP_REPORTER
fef79a1 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
Mark ScLogger destructor as potentially throwing an exception
28d29a1 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
Depricate SC_THROW, and mask it out in the ScLogger destructor.
077fe80 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
Remove all actions and clean up
319f643 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton
Re-factor to create sc_log separate from SCP
393fab8 
Signed-off-by: Mark Burton <[email protected]>
@markfoodyburton markfoodyburton requested review from barnasc and aut0 March 26, 2025 11:44
@barnasc
Copy link
Contributor

barnasc commented Apr 18, 2025

As discussed in CPSWG at 2025/04/08:

  • I propose to remove the SCMOD define and simply use name() in the example
  • It looks like the scp::init_logging requires a global broker which needs to be instantiated by the application. Preferably initialization does not require a CCI broker
  • the init option scp::LogConfig::fileInfoFrom currently accepts an int and not a type of scp::log
  • Remove the obsolete log levels called DBGTRACE and TRACEALL (already resolved in the SystemC PR #726)
  • Where does the log go from m_my_logger?

aut0
aut0 suggested changes May 23, 2025
View reviewed changes
Copy link
Contributor

@aut0 aut0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also style check fails.

examples/audio_example/CMakeLists.txt
cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
project(audioexample VERSION 1.0 LANGUAGES CXX C)

set(CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard to build all targets.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not force global settings, rather set it for the target.

examples/audio_example/CMakeLists.txt

find_package(PkgConfig REQUIRED)
pkg_check_modules(PORTAUDIO REQUIRED IMPORTED_TARGET GLOBAL portaudio-2.0)
#include_directories(${PORTAUDIO_INCLUDE_DIRS})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

examples/audio_example/include/async_event.h
@@ -0,0 +1,129 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be part of CPS base instead of the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aut0 aut0 aut0 requested changes

@barnasc barnasc Awaiting requested review from barnasc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markfoodyburton @barnasc @aut0 @eyck