Skip to content
This repository was archived by the owner on Nov 23, 2023. It is now read-only.

feat: add definition toggletips#187

Open
greatislander wants to merge 29 commits intomainfrom
feat/definition-popovers
Open

feat: add definition toggletips#187
greatislander wants to merge 29 commits intomainfrom
feat/definition-popovers

Conversation

@greatislander
Copy link
Contributor

@greatislander greatislander commented Aug 9, 2021

This PR adds definitions in toggletips to each step in the service blueprint. Steps to test:

  1. Navigate to any step in the service blueprint.
  2. Find the (?) icon next to a term in one of the sections.
  3. Display the definition for the term by clicking the icon or focusing and activating it with the keyboard.
  4. Verify that the definition is focusable.
  5. Verify that the definition is dismissable with the esc key or by clicking anywhere outside it.

@greatislander greatislander self-assigned this Aug 9, 2021
@greatislander greatislander added the enhancement New feature or request label Aug 9, 2021
@cherylhjli
Copy link
Contributor

I just realized I tried to click the label instead of the icon - could we make the label clickable too?

@greatislander
Copy link
Contributor Author

I just realized I tried to click the label instead of the icon - could we make the label clickable too?

In the research I've done, that's not a common pattern. Typically the associated word or phrase isn't underlined either… I'm kind of wondering if after all this we shouldn't just implement these as footnotes? E.g. https://www.sitepoint.com/accessible-footnotes-css/

@cherylhjli
Copy link
Contributor

hmm, the footnotes are an option. From what I see in that demo, you click on the number and then it takes you down the page. Is there a way to link it back up to where you were? I'm hoping users don't have to do the searching and navigating back to their original spot - that could be a hassle, especially for AT users.

I think the goal of the underline is to make it clear that the toggle tip is associated with that specific term. Maybe we can play with the spacing and move the icon closer to the term to make that clearer?

@greatislander
Copy link
Contributor Author

hmm, the footnotes are an option. From what I see in that demo, you click on the number and then it takes you down the page. Is there a way to link it back up to where you were? I'm hoping users don't have to do the searching and navigating back to their original spot - that could be a hassle, especially for AT users.

I think the goal of the underline is to make it clear that the toggle tip is associated with that specific term. Maybe we can play with the spacing and move the icon closer to the term to make that clearer?

If you follow that tutorial through to the end it does indeed provide links back to the place in the text where the footnote was referenced. I could certainly move the icon closer.

@cherylhjli
Copy link
Contributor

ohhh I see them now! Sure, let's do footnotes then. Let's also make that icon link that takes up you back up less tiny, and with a label :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants