Add skeleton shimmer prefers-reduced-motion fallback#148
Merged
Conversation
…ck-for-reduced-motion Add reduced-motion fallback for creator skeleton shimmer
|
@Johnpii1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…text-for-claims Add standardized claim-action disabled-reason helper text
…t-for-action-sheets Add mobile bottom safe-area inset for dialog action sheets
…ashing Add deterministic fallback avatar colors by creator id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
Replaced framer-motion opacity pulse blocks in src/components/common/CreatorSkeleton.tsx with a CSS-driven skeleton-shimmer utility class and a single skeletonBlockClass applied to each placeholder element.
Added .skeleton-shimmer animation and a @media (prefers-reduced-motion: reduce) override in src/index.css that disables animation and switches to a static gradient, and added @Keyframes skeleton-shimmer.
Added unit tests in src/components/common/tests/CreatorSkeleton.test.tsx asserting that a card renders 6 shimmer blocks and that CreatorGridSkeleton with count={3} renders 18 shimmer blocks.
Applied code formatting and lint fixes to the modified files.
Testing
Ran lint: pnpm eslint src/components/common/CreatorSkeleton.tsx src/components/common/tests/CreatorSkeleton.test.tsx which succeeded.
Ran formatting check: pnpm prettier --check src/components/common/CreatorSkeleton.tsx src/index.css src/components/common/tests/CreatorSkeleton.test.tsx which succeeded.
Ran tests: pnpm test src/components/common/tests/CreatorSkeleton.test.tsx which passed (1 test file, 2 tests passed).
pnpm lintpnpm buildChecklist
close #125