Added transaction status badge legend tooltip#203
Closed
Peolite001 wants to merge 4 commits into
Closed
Conversation
|
@Peolite001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157
What were you told to do?
Add transaction status badge legend tooltip
Add a small legend tooltip explaining transaction status badge meanings. Keep content concise and user-friendly. Ensure tooltip is keyboard accessible.
What did you do?
src/components/tx-status/TxStatusLegend.tsxkeyboard-accessible tooltip component explaining four transaction statuses:src/components/tx-status/TxStatusBadge.tsxreusable badge component with consistent styling andaria-labelfor screen readerssrc/components/tx-status/__tests__/TxStatusLegend.test.tsx10 tests covering:Escapekey dismissal with focus return to triggeraria-expanded,aria-controls,role="dialog")src/components/tx-status/__tests__/TxStatusBadge.test.tsxtests for all four status variants and accessible labelingsrc/components/tx-status/no unrelated file churn<button>trigger witharia-expandedandaria-controlsrole="dialog"with descriptivearia-labelEscapekey closes and returns focus to triggerEscto close) visible in tooltipSummary
Added a keyboard-accessible transaction status badge legend tooltip scoped to
src/components/tx-status/. TheTxStatusLegendcomponent renders a button that opens a popover explaining Pending, Processing, Success, and Failed statuses.TxStatusBadgeprovides a reusable, screen-reader-friendly badge with matching styling. All interactions are keyboard accessible (Enter/Space to open, Escape to close, focus management) and ARIA-compliant.How to validate locally
pnpm test -- src/components/tx-status/TxStatusLegendinto any page with a transaction table:Closes #155
What were you told to do?
Add creator card keyboard shortcut hint for quick buy
Add an unobtrusive keyboard shortcut hint on creator cards. Document intended shortcut behavior in UI copy. Keep mobile UX unchanged.
What did you do?
src/components/creator-card/CreatorCard.tsxcreator card component with:onQuickBuy(creator.id)Bwhile card is focused to quick buy (no mouse needed)Bbadge with "to buy" text that fades in on hover/focussr-onlytext announces "Press B to quick buy from this creator"src/components/creator-card/__tests__/CreatorCard.test.tsx13 tests covering:Bkey shortcut (lowercase and uppercase)aria-label,aria-hidden,sr-only,kbd)src/components/creator-card/CreatorCardGrid.tsx— example grid wrapper with properrole="list"src/components/creator-card/README.md— documents keyboard shortcuts and accessibility featuressrc/components/creator-card/— no unrelated file churnAccessibility & UX
hidden md:flex— touch users only see the Quick Buy buttontabIndex={0}) with visiblefocus-withinringsr-onlytext documents the shortcut; visual hint isaria-hiddento avoid double-announcementkbdelement used for theBkey per HTML semanticsEnter/Spacebehavior preserved for nested interactive elementsSummary
Added an unobtrusive
Bkeyboard shortcut hint to creator cards for quick buy. The hint appears on hover/focus (desktop only) and is complemented by screen-reader-only documentation. Mobile UX is completely unchanged. All changes scoped tosrc/components/creator-card/.Testing
pnpm lintpnpm buildpnpm test -- src/components/creator-card/(all 13 tests pass)How to validate locally
pnpm test -- src/components/creator-card/CreatorCardinto a page: