feat: implement accessibility audits for trade modal and search results#280
Merged
Chucks1093 merged 1 commit intoMay 27, 2026
Merged
Conversation
## Summary - **Trade Modal (accesslayerorg#268)**: Audited and adjusted the tab-key navigation order. Moved the Close (X) button to the beginning of the DialogContent DOM to ensure a visually logical tab sequence (Close -> Amount -> Cancel -> Confirm). Updated the TradeDialog focus order tests to reflect this change. - **Search Results (accesslayerorg#269)**: Added a visually hidden aria-live="polite" region to StickyFilterBar to announce search result counts to screen reader users. The announcement is debounced by 500ms to avoid excessive noise during active typing, while the visual count remains instantaneous. Closes accesslayerorg#268 Closes accesslayerorg#269 ## Testing - [x] pnpm lint - [x] pnpm build - [x] Added src/components/common/__tests__/StickyFilterBar.test.tsx to verify debounced aria-live announcements. - [x] Updated src/components/common/__tests__/TradeDialog.focusOrder.test.tsx to verify DOM focus order. ## Checklist - [x] Linked issue or backlog item - [x] Scope is limited to the stated change - [x] Updated docs if behavior or setup changed - [ ] Added screenshots for UI changes when relevant
|
@soomtochukwu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #268
Closes #269
Testing
Checklist
Summary
Testing
pnpm lintpnpm buildChecklist