Skip to content

feat: implement accessibility audits for trade modal and search results#280

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
soomtochukwu:fix/accessibility-audits
May 27, 2026
Merged

feat: implement accessibility audits for trade modal and search results#280
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
soomtochukwu:fix/accessibility-audits

Conversation

@soomtochukwu

Copy link
Copy Markdown
Contributor

Summary

  • Trade Modal (Add tab-key navigation order audit for trade modal fields #268): Audited and adjusted the tab-key navigation order. Moved the Close (X) button to the beginning of the DialogContent DOM to ensure a visually logical tab sequence (Close -> Amount -> Cancel -> Confirm). Updated the TradeDialog focus order tests to reflect this change.
  • Search Results (Add aria-live region for creator search result count #269): Added a visually hidden ariaclos-live="polite" region to StickyFilterBar to announce search result counts to screen reader users. The announcement is debounced by 500ms to avoid excessive noise during active typing, while the visual count remains instantaneous.

Closes #268
Closes #269

Testing

  • pnpm lint
  • pnpm build
  • Added src/components/common/tests/StickyFilterBar.test.tsx to verify debounced aria-live announcements.
  • Updated src/components/common/tests/TradeDialog.focusOrder.test.tsx to verify DOM focus order.

Checklist

  • Linked issue or backlog item
  • Scope is limited to the stated change
  • Updated docs if behavior or setup changed
  • Added screenshots for UI changes when relevant

Summary

Testing

  • pnpm lint
  • pnpm build

Checklist

  • Linked issue or backlog item
  • Scope is limited to the stated change
  • Updated docs if behavior or setup changed
  • Added screenshots for UI changes when relevant

## Summary

- **Trade Modal (accesslayerorg#268)**: Audited and adjusted the tab-key navigation order. Moved the Close (X) button to the beginning of the DialogContent DOM to ensure a visually logical tab sequence (Close -> Amount -> Cancel -> Confirm). Updated the TradeDialog focus order tests to reflect this change.
- **Search Results (accesslayerorg#269)**: Added a visually hidden aria-live="polite" region to StickyFilterBar to announce search result counts to screen reader users. The announcement is debounced by 500ms to avoid excessive noise during active typing, while the visual count remains instantaneous.

Closes accesslayerorg#268
Closes accesslayerorg#269

## Testing

- [x] pnpm lint
- [x] pnpm build
- [x] Added src/components/common/__tests__/StickyFilterBar.test.tsx to verify debounced aria-live announcements.
- [x] Updated src/components/common/__tests__/TradeDialog.focusOrder.test.tsx to verify DOM focus order.

## Checklist

- [x] Linked issue or backlog item
- [x] Scope is limited to the stated change
- [x] Updated docs if behavior or setup changed
- [ ] Added screenshots for UI changes when relevant
@drips-wave

drips-wave Bot commented May 27, 2026

Copy link
Copy Markdown

@soomtochukwu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093 Chucks1093 merged commit 415081f into accesslayerorg:main May 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add aria-live region for creator search result count Add tab-key navigation order audit for trade modal fields

2 participants