Skip to content

Feat/add accessible name #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chucks1093 merged 2 commits into from
May 27, 2026
Merged

Feat/add accessible name #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93ae615
added keyboard
Marvell69 May 27, 2026
40fcbb9
added accessible name
Marvell69 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/common/CreatorCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,11 @@ const CreatorCard: React.FC<CreatorCardProps> = ({ creator, className }) => {
className
)}
>
<div className="relative mb-4 aspect-square overflow-hidden rounded-xl">
<div
className="relative mb-4 aspect-square overflow-hidden rounded-xl"
role="img"
aria-labelledby={`creator-name-${creator.id}`}
>
<CreatorInitialsAvatar
name={creator.title}
creatorId={creator.id}
Expand All @@ -140,7 +144,10 @@ const CreatorCard: React.FC<CreatorCardProps> = ({ creator, className }) => {

<div className="mb-4">
<div className="flex items-center gap-2 flex-wrap">
<h3 className="font-jakarta text-lg font-bold text-white">
<h3
id={`creator-name-${creator.id}`}
className="font-jakarta text-lg font-bold text-white"
>
{creator.title}
</h3>
<VerifiedBadge
Expand Down
17 changes: 14 additions & 3 deletions src/components/common/CreatorProfileHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,26 @@ const CreatorProfileHeader: React.FC<CreatorProfileHeaderProps> = ({
)}
>
<div className="flex flex-col gap-4 md:flex-row md:items-center md:gap-6">
<div className="size-24 overflow-hidden rounded-2xl border-4 border-white/10 shadow-xl md:size-32">
<div
className="size-24 overflow-hidden rounded-2xl border-4 border-white/10 shadow-xl md:size-32"
role="img"
aria-labelledby="creator-profile-name"
>
<CreatorInitialsAvatar name={name} creatorId={creatorId} imageSrc={avatarUrl} />
</div>
<div className="min-w-0 space-y-1">
<div className="flex items-center gap-2 overflow-hidden">
<h1 className="truncate font-grotesque text-3xl font-black tracking-tight text-white md:text-4xl">
<h1
id="creator-profile-name"
className="truncate font-grotesque text-3xl font-black tracking-tight text-white md:text-4xl"
>
{name}
</h1>
{isVerified && <div className="shrink-0"><VerifiedBadge verified={true} /></div>}
{isVerified && (
<div className="shrink-0">
<VerifiedBadge verified={true} />
</div>
)}
</div>
<p
className={cn(
Expand Down
4 changes: 2 additions & 2 deletions src/components/common/CreatorSocialLinksList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ const CreatorSocialLinksList: React.FC<CreatorSocialLinksListProps> = ({
href={url}
target="_blank"
rel="noreferrer"
className="link-action-chip group inline-flex w-full items-center justify-center gap-1.5 rounded-lg border border-white/10 bg-white/[0.03] px-2.5 py-2 text-[11px] font-semibold text-white/80 transition-colors hover:border-amber-400/40 hover:bg-amber-400/10 hover:text-amber-100"
className="link-action-chip group inline-flex w-full items-center justify-center gap-1.5 rounded-lg border border-white/10 bg-white/[0.03] px-2.5 py-2 text-[11px] font-semibold text-white/80 transition-all hover:border-amber-400/40 hover:bg-amber-400/10 hover:text-amber-100 focus-visible:border-amber-400/60 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-amber-400/50 focus-visible:ring-offset-2 focus-visible:ring-offset-background"
>
<Icon className="size-3.5" />
<span>{label}</span>
<LinkIcon className="size-3 opacity-0 transition-opacity group-hover:opacity-80" />
<LinkIcon className="size-3 opacity-0 transition-opacity group-hover:opacity-80 group-focus-visible:opacity-80" />
</a>
</li>
))}
Expand Down
21 changes: 0 additions & 21 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,27 +175,6 @@
margin-bottom: var(--spacing-section-major);
}

.link-action-chip:focus-visible {
outline: none;
border-color: rgba(252, 211, 77, 0.85);
background-color: rgba(251, 191, 36, 0.2);
color: rgba(255, 255, 255, 0.98);
box-shadow:
0 0 0 2px rgba(252, 211, 77, 0.9),
0 0 0 5px rgba(15, 23, 42, 0.95);
}

@media (forced-colors: active) {
.link-action-chip:focus-visible {
outline: 2px solid Highlight;
outline-offset: 2px;
border-color: Highlight;
background-color: Canvas;
color: CanvasText;
box-shadow: none;
}
}

.skeleton-shimmer {
position: relative;
overflow: hidden;
Expand Down
Loading