Resolve issues 487 492 - #592
Merged
Chucks1093 merged 5 commits intoJul 25, 2026
Merged
Conversation
…ndent holder balances (accesslayerorg#588)
|
@dorismaduegbunam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
dorismaduegbunam
force-pushed
the
resolve-issues-487-492
branch
from
July 25, 2026 11:38
d79d4af to
eaf0727
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates the resolutions for issues #586, #588, #589, and #590:
1. Unit tests for sell event proceeds matching the sell-path formula output (#586)
closes Add unit tests for sell event fields matching the sell-path formula output #586
2. Integration test for multi-buyer scenario confirming independent holder balances (#588)
closes Add integration test for multi-buyer scenario confirming independent holder balances #588
3. Structured log event for admin fee bps update (#589)
FeeConfigUpdatedEventin the contract events module.set_fee_configwith the fieldsold_bps,new_bps, andupdated_at_ledgerto support off-chain monitors and indexers.closes Add structured log event for admin fee bps update #589
4. Reference docs for the bonding curve formula and off-chain price prediction (#590)
closes Add docs for how the bonding curve formula is derived and how to predict prices off-chain #590