Wardrobe - New Addon - System to modify wearables #10606
Conversation
OverlordZorn
changed the title
|
Core Features are complete. |
|
all the things with |
|
Haven't tested nor looked at code yet. How are inherited config properties handled? |
Wearables with fully inherited subclass are ignored. |
Alright, should be safe then. That should also go in documentation. |
OverlordZorn
force-pushed
the
ace-wardrobe
branch
from
c61b27b to
4aea498
Compare
|
"5 requested changes" |
| * Example: | ||
| * toFixed 0; | ||
| * private _magazineDetails = (magazinesAmmoFull player) apply { [_x#0, _x#-2, _x#-1] }; | ||
| * private _documents = _magazineDetails findIf { _x select 0 == "acex_intelitems_document" } > -1; | ||
| * if (_documents) then { _documents = [player, "acex_intelitems_document"] call CBA_fnc_getMagazineIndex apply { _x call ace_wardrobe_fnc_getIndexFromMagID } }; | ||
| * | ||
| * Public: Yes |
There was a problem hiding this comment.
I have no idea what this does. What is this doing here? This looks like intel items API in wardrobe? Why is this public?
There was a problem hiding this comment.
I have no idea what this does. What is this doing here? This looks like intel items API in wardrobe?
- Intel items, as well as the spare barrels store their individual data (each in a different way) based on the magazineID.
- When i switch the uniform/vest/backpack through wardrobe, the container will get "refilled" with new, fresh magazines, with new magIDs.
- I have to get the previous magazine ID's, with that, retrieve the individual Data, then get the magID of the new variant, and store the old data on the new magID.
Why is this public?
Dont remember, its not anymore.
There was a problem hiding this comment.
This should be a function in intel items. I'm also referring to the example. No idea what it does.
|
|
||
| params ["_player", "_classTarget", "_equipmentType"]; | ||
|
|
||
| toFixed 0; |
There was a problem hiding this comment.
Why what? the toFixed 0; ?
| * toFixed 0; | ||
| * private _magazineDetails = (magazinesAmmoFull player) apply { [_x#0, _x#-2, _x#-1] } select { _x#0 == "acex_intelitems_document" }; | ||
| * { [_x#1, 69] call ace_wardrobe_fnc_setIndexForMagID } forEach _magazineDetails; | ||
| * | ||
| * Public: No |
|
I haven't really touched the replace functions and the stuff that touches intel items / spare barrels, but I'm through with my cleanup otherwise. |
|
yea idk why but shits broke now.
|
Replaces the use of 'findIf' with 'select' and 'isEqualTo []' to correctly determine if all required items are present for wardrobe modification.
|
I was able to fix the before mentioned changes, but now it duplicates items, which it didnt do before |
This reverts commit d01259a.
|
it fixed now, seems i misinterpretated a change in my quest of finding the first issue. |
When merged this pull request will:
Introduces a new system to modify currently worn gear.
For Example:
UX:
Inventory -> CBA Context Menu on Wearable SlotCompats for: GM, SOG, WS, RF
ToDo once approved:
IMPORTANT
Related PR's