Refuel - Improved: Added Soundeffects

[OverlordZorn]

When merged this pull request will:

• Adds Soundeffect to Refuel Start
• Adds Soundeffect to Refuel Stopped

IMPORTANT

Requires CBATeam/CBA_A3#1751

[OverlordZorn]

https://www.youtube.com/watch?v=cSatKnc3jSw

[BaerMitUmlaut]

Did you record these yourself or are these licensed?

[OverlordZorn]

Did you record these yourself or are these licensed?

they're from freesound.org, author and cc should be baked into the soundfile.

Stop:
https://freesound.org/people/joedeshon/sounds/117419/

You can copy, modify, distribute and perform the sound, even for commercial purposes, all without the need of asking permission to the author.

Start:
https://freesound.org/people/WryFighter/sounds/451551/

You are free to share (to copy, distribute and transmit) and to remix (to adapt and modify) as long as you credit the author of the sound.

[BaerMitUmlaut]

Without an explicit license, these would fall under GPL (which would be wrong). Please follow the example of the fastroping sounds:

• ACE3/LICENSE

  Line 30 in adb1199

  - CreativeCommons Attributions 3.0 (\addons\fastroping\data\sounds)

• https://github.com/acemod/ACE3/blob/adb1199ee5cda958c834ec7635cab5cea5461724/addons/fastroping/data/sounds/LICENSE.md

[OverlordZorn]

Without an explicit license, these would fall under GPL (which would be wrong). Please follow the example of the fastroping sounds:

* https://github.com/acemod/ACE3/blob/adb1199ee5cda958c834ec7635cab5cea5461724/LICENSE#L30

* https://github.com/acemod/ACE3/blob/adb1199ee5cda958c834ec7635cab5cea5461724/addons/fastroping/data/sounds/LICENSE.md

will do - wasnt sure how else to do it!

[BrettMayson]

I don't think it needs to go in authors, just license, unless I am wrong

[OverlordZorn]

I don't think it needs to go in authors, just license, unless I am wrong

the fastroping sounds are in there, thats why i added them

ACE3/AUTHORS.txt

Line 182 in a82d5a4

Tessa Elieff <Fastroping Sound - CreativeCommons Attributions 3.0>

[johnb432]

LGTM for next CBA release.

[OverlordZorn]

• exit 3x implemented
• comment 3x "TODO"

Once this is merged i can make another pr to remove the lines if needed