-
Notifications
You must be signed in to change notification settings - Fork 347
Add warning for too-long dialog #4374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was the 2000 character limit chosen? I'm seeing manual requests for lists of <10 authors that I'm pretty sure would have worked in the dialog before we made this change. |
Yeah, this is causing problems. I'm going to revert it until we can find the actual cutoff. I remember digging around for this number. |
If you set it to 10000 or something I can experiment with it on the client side. |
Also, what issue URL should we direct people to when they hit the limit? Opening a blank issue doesn't seem ideal given that we have issue templates for everything (and they automatically get tagged appropriately), but the "paper metadata" one specifically says not to use it manually. |
Yeah, this is more complicated than I'd thought. The situation I want to save people from is this: you go to all the work manipulating the form, submit—and you get an error on the Github side. You've done a bunch of work for nothing. I think we should figure out the limit, set the threshold short of that, and guide the user through the following:
|
If the metadata query is too long, it cannot be filed to Github over a GET request. This PR just adds a note to the user.