Skip to content

Add warning for too-long dialog #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025
Merged

Add warning for too-long dialog #4374

merged 5 commits into from
May 22, 2025

Conversation

mjpost
Copy link
Member

@mjpost mjpost commented Jan 9, 2025

If the metadata query is too long, it cannot be filed to Github over a GET request. This PR just adds a note to the user.

@mjpost mjpost self-assigned this Jan 9, 2025
@mjpost mjpost added this to the 2025Q1 milestone Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Build successful. Some useful links:

This preview will be removed when the branch is merged.

@mjpost mjpost changed the title Remove affiliation from dialog Add warning for too-long dialog Apr 8, 2025
@mjpost mjpost requested review from mbollmann and nschneid May 21, 2025 18:03
Copy link
Contributor

@nschneid nschneid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjpost mjpost merged commit ace5e84 into master May 22, 2025
2 checks passed
@mjpost mjpost deleted the remove-affiliations branch May 22, 2025 12:29
@nschneid
Copy link
Contributor

How was the 2000 character limit chosen? I'm seeing manual requests for lists of <10 authors that I'm pretty sure would have worked in the dialog before we made this change.

@mjpost
Copy link
Member Author

mjpost commented May 23, 2025

Yeah, this is causing problems. I'm going to revert it until we can find the actual cutoff. I remember digging around for this number.

@nschneid
Copy link
Contributor

If you set it to 10000 or something I can experiment with it on the client side.

@mbollmann
Copy link
Member

Also, what issue URL should we direct people to when they hit the limit? Opening a blank issue doesn't seem ideal given that we have issue templates for everything (and they automatically get tagged appropriately), but the "paper metadata" one specifically says not to use it manually.

@mjpost
Copy link
Member Author

mjpost commented May 24, 2025

Yeah, this is more complicated than I'd thought.

The situation I want to save people from is this: you go to all the work manipulating the form, submit—and you get an error on the Github side. You've done a bunch of work for nothing.

I think we should figure out the limit, set the threshold short of that, and guide the user through the following:

  • Present the JSON data structure in the dialog, along with a copy to clipboard button
  • Give them a link to the issue template, with just a minimal URL string
  • Instruct them to manually paste the complete JSON block into the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants