Skip to content

Fixes for lock and emacs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

silverdev
Copy link
Member

The lock script was updated to work with gnome 3.10 and the emacs configs slowing becoming more usable and less buggy.

for EDITOR in vimx vim elvis vile nvi vi ; do
# gimmie an editor, make it emacs or a nice vi clone
# but you can't find a vi clone keep trying!!
for EDITOR in vimx vim elvis vile nvi vi emacs nano peco; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is peco supposed to be pico?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Steven! Do the think I should make a symlink from emacsrc to emacsrc.el?
I did not think it was needed because the emacs rc was buggy enough that I think no one uses it but Fab and I. Also emacs users are good at debugging init scrips and would quickly know to change their symlink. Still it would provide backwards compatibility for people who pull updates to acmdots.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well why are we changing it to have a .el extension? None of the other config files have extensions.

I wouldn't bother symlinking, though. It might prevent their config from breaking but it also means they won't get any of the updates and they might not realize that, which'd be worse. If anyone wants to pull updates from acmdots they'll need to re-run the install script.

My only other concern with the rename would be merge conflicts, but a symlink won't help with that. Git is probably smart enough to apply any changes to the renamed file, though.

Good catch Steven!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants