-
Notifications
You must be signed in to change notification settings - Fork 0
feature/stripe-checkout #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdityaK2905
wants to merge
116
commits into
main
Choose a base branch
from
feature/stripe-checkout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
116 commits
Select commit
Hold shift + click to select a range
d0e7d9f
rough version of checkout session upon link usage
AdityaK2905 444dbe0
reverted rsvp changes
AdityaK2905 1361491
coderabbit fixes plus writing payments
AdityaK2905 d8d0d97
wrapped payment recording in try catch
AdityaK2905 a3f4428
rebasing off main and changed checkout session to use ACH
AdityaK2905 8f0b844
updated zod schema
AdityaK2905 060651e
reset yarn.lock
AdityaK2905 43e6877
Add ACM org to UI
devksingh4 256d035
changed dollars to cents in zod
AdityaK2905 f9bb03f
updated tests
AdityaK2905 9f6432d
readded stripe types
AdityaK2905 a7003d5
fixed tests with db commands changing
AdityaK2905 231fe3d
acmOrg field for createLink test
AdityaK2905 bc059ef
improved test coverage
AdityaK2905 3de0b50
changed vi mock pls pass tests
AdityaK2905 d1006dd
please pass
AdityaK2905 c8b1f4f
fixed tests
AdityaK2905 fd304df
changed return status order
AdityaK2905 f38ddea
updated live tests
AdityaK2905 1648781
updated for codeQL
AdityaK2905 399e333
empty commit for live tests
AdityaK2905 c58ffcf
Don't return contactName and contactEmail in payment links GET
devksingh4 ea2e99c
Payment entry upon checkout session payment enters dynamoDB locally now
AdityaK2905 1b5f8d6
fixed unused imports and other errors
AdityaK2905 b5c7e1e
updated UI, only pay upon sufficient funding
AdityaK2905 ee66076
updated to pass tests
AdityaK2905 8878d6b
updated createlink test
AdityaK2905 49a8b1b
updated placeholder UI text tests
AdityaK2905 377b814
added lead role for live stripe testing
AdityaK2905 3ae9fae
logs
AdityaK2905 7376955
updated variables to give payment links table access
AdityaK2905 14309cf
fixed wrong variables
AdityaK2905 fba9fde
added stripe payment links table to dynamo access
AdityaK2905 611a35d
updated live stripe deletion test
AdityaK2905 ad78e02
removed needsconfirmation and changed live tests
AdityaK2905 86db27e
removed confirmation test
AdityaK2905 5ee9152
skipping tests
AdityaK2905 d3461bf
rebased and fixed files
AdityaK2905 b15d390
fixed rsvp types
AdityaK2905 5138776
Resetting yarn
AdityaK2905 ae607f8
Auto-update feature branch with changes from the main branch
github-actions[bot] 553ec4e
emailing hopefully
AdityaK2905 b1cf1e7
updated stripe POST webhook test
AdityaK2905 823ce82
Auto-update feature branch with changes from the main branch
github-actions[bot] 116aa62
Auto-update feature branch with changes from the main branch
github-actions[bot] 2adeeb2
Auto-update feature branch with changes from the main branch
github-actions[bot] 02f2f39
Auto-update feature branch with changes from the main branch
github-actions[bot] a997062
Auto-update feature branch with changes from the main branch
github-actions[bot] 39c6ef5
Auto-update feature branch with changes from the main branch
github-actions[bot] 0686ee8
Auto-update feature branch with changes from the main branch
github-actions[bot] 1470806
fixed emails, immediate success payment, and stripe links table
AdityaK2905 bd7bcb0
fixed for tests
AdityaK2905 d06c11f
updated unit tests
AdityaK2905 d6cdc56
forgot to update types
AdityaK2905 3a7f4f7
updating return url
AdityaK2905 0589cb2
updated emails and success urls again
AdityaK2905 33ada1d
removing doubled emails
AdityaK2905 a57a236
fixed emails to deploy
AdityaK2905 98e6ccd
changing success url
AdityaK2905 dac93d8
changing success url
AdityaK2905 891c0a0
Auto-update feature branch with changes from the main branch
github-actions[bot] 392d10d
Auto-update feature branch with changes from the main branch
github-actions[bot] 4562c7b
removed double emailing and better email info
AdityaK2905 b0e5afd
fixing tests for previous change
AdityaK2905 3e3d2b7
fixing tests for previous change
AdityaK2905 ab34490
updated partial payment classification
AdityaK2905 ba44d61
test updates
AdityaK2905 3539656
added email for settled partial payment
AdityaK2905 e8f1296
added test for coverage
AdityaK2905 6e85200
Auto-update feature branch with changes from the main branch
github-actions[bot] ab1ef01
Auto-update feature branch with changes from the main branch
github-actions[bot] 998da96
Auto-update feature branch with changes from the main branch
github-actions[bot] dbb9b43
Auto-update feature branch with changes from the main branch
github-actions[bot] 4e13a53
Auto-update feature branch with changes from the main branch
github-actions[bot] ff6132b
Auto-update feature branch with changes from the main branch
github-actions[bot] 24e24d1
Auto-update feature branch with changes from the main branch
github-actions[bot] c842820
Auto-update feature branch with changes from the main branch
github-actions[bot] 356148f
status page
AdityaK2905 edc943f
updated to be unauthenticated status
AdityaK2905 ff10a6d
update
AdityaK2905 59836b4
redeploying
AdityaK2905 afa38ae
Auto-update feature branch with changes from the main branch
github-actions[bot] b9ba742
updating for qa to properly redirect to status page after payment
AdityaK2905 b4d1406
token redirects to /status
AdityaK2905 3f51146
increased test coverage
AdityaK2905 d3f355d
import path updated
AdityaK2905 6697e7c
Auto-update feature branch with changes from the main branch
github-actions[bot] 825013f
adding UI for status page
AdityaK2905 f90b5cf
Auto-update feature branch with changes from the main branch
github-actions[bot] c8ad2f4
removed bug on stripe link page where org selector would not appear
AdityaK2905 cc93e8a
fixed stripe checkout function type
AdityaK2905 3d161e5
fix
AdityaK2905 db37885
updated test with proper error code
AdityaK2905 34a4079
updated test again..
AdityaK2905 7914d88
hitting /status directly
AdityaK2905 0c8a4c8
Auto-update feature branch with changes from the main branch
github-actions[bot] 87ba858
Auto-update feature branch with changes from the main branch
github-actions[bot] 6064f89
Auto-update feature branch with changes from the main branch
github-actions[bot] b910a46
Auto-update feature branch with changes from the main branch
github-actions[bot] 592aa91
Auto-update feature branch with changes from the main branch
github-actions[bot] 6d1b91b
fixed /status route to render proper information after stripe payment
AdityaK2905 d6b49fb
minor ui fixes on payment status page
AdityaK2905 7a790b1
Reversion
AdityaK2905 45ef153
reworked success url
AdityaK2905 1ad1d1a
ui fixes
AdityaK2905 28e395e
Auto-update feature branch with changes from the main branch
github-actions[bot] 2d6e6fd
Auto-update feature branch with changes from the main branch
github-actions[bot] 6b1fb14
Auto-update feature branch with changes from the main branch
github-actions[bot] d0ee870
Auto-update feature branch with changes from the main branch
github-actions[bot] 8dd0147
Auto-update feature branch with changes from the main branch
github-actions[bot] a404ae7
bug fixes on checkout
AdityaK2905 c4ab4f9
removed unused variable
AdityaK2905 18870cd
tests
AdityaK2905 aa6830b
lint
AdityaK2905 be27e24
reworked status page + partial payments
AdityaK2905 c175e74
added tests for coverage
AdityaK2905 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: acm-uiuc/core
Length of output: 93
Remove or replace the ineffective
try/catchblock forBuffer.from.Buffer.from(token, "base64url")does not throw on malformed input — it silently returns a best-effort decode with garbage bytes. Thecatchblock (lines 119–121) will never execute, and the error message "Invalid invoice token encoding" is unreachable. The structural validation on lines 128–130 already catches malformed tokens, making this error handler redundant. Either remove the try/catch or replace it with actual validation logic that detects invalid base64url encoding.🤖 Prompt for AI Agents