Skip to content

Report waits for host output buffers - #292

Open
nclack wants to merge 1 commit into
mainfrom
measure-output-waits
Open

nclack wants to merge 1 commit into
mainfrom
measure-output-waits

Conversation

@nclack

@nclack nclack commented Sep 19, 2026

Copy link
Copy Markdown
Member

Output-buffer exhaustion was included in GPU delivery work and absent from CPU diagnostics. Record it as output_buffer_wait for both backends, expose it in benchmark reports, reset it with the other metrics, and subtract it from GPU delivery work. Acquisition attempts and blocked calls are counted separately so an unused metric can be distinguished from an available buffer.

Validation: all 50 non-S3 CPU checks passed, including blocked/immediate acquisition and metric reset coverage. The CPU regression fails when its output-wait recording is disconnected and passes after restoration. The Debug L40 build also passed output-pool, D2H delivery, and end-to-end metric tests (3/3).

@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cpu/pipeline.c 80.00% 0 Missing and 1 partial ⚠️
src/stream/host_output_pool.c 90.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/cpu/stream.c 82.07% <100.00%> (+0.06%) ⬆️
src/util/metric.c 100.00% <100.00%> (ø)
src/cpu/pipeline.c 79.93% <80.00%> (+0.26%) ⬆️
src/stream/host_output_pool.c 75.88% <90.00%> (+1.07%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant