Conversation
pxrl
commented
Apr 1, 2026
pxrl
commented
- Added .js extensions to relative imports for Node.js ESM compatibility
- Modernized tsconfig: target ES2022, module/moduleResolution nodenext, verbatimModuleSyntax.
- Split into tsconfig.json (ESM + declarations) and tsconfig.cjs.json (CJS), eliminating the separate types build (3 tsc passes → 2)
- Simplified build scripts and removed redundant ESM sub-package.json
- Added .js extensions to relative imports for Node.js ESM compatibility - Modernized tsconfig: target ES2022, module/moduleResolution nodenext, verbatimModuleSyntax. - Split into tsconfig.json (ESM + declarations) and tsconfig.cjs.json (CJS), eliminating the separate types build (3 tsc passes → 2) - Simplified build scripts and removed redundant ESM sub-package.json
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d64fd9ae6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@0xjorgen @gsteenkamp89 I see you have issues w/ this package downstream, and per current implementation, it's also a hindrance for us to migrate to esm. Would be nice to roll some fixes here and then down in the SDK too. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 999d170289
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
