feat: Close PDAs for fills from our relayer#2381
Merged
dijanin-brat merged 43 commits intomasterfrom Aug 14, 2025
Merged
Conversation
bmzig
reviewed
Jul 17, 2025
bmzig
reviewed
Jul 17, 2025
bmzig
reviewed
Jul 29, 2025
grasphoper
reviewed
Jul 30, 2025
Contributor
There was a problem hiding this comment.
Looks good! Left a couple of minor comments. I very much like @bmzig's idea.
arch/svm/getRelayDataHash accepts message, but then takes a hash from it in its impl. to arrive at the final relaydatahash. As long as messageHash we have in a fill is just a simple keccak, it should work
Upd.: indeed, here's the svm SC impl of message hashing
dijanin-brat
requested review from
dohaki,
james-a-morris,
mrice32 and
nicholaspai
as code owners
fusmanii
reviewed
Aug 13, 2025
nicholaspai
reviewed
Aug 13, 2025
nicholaspai
previously approved these changes
Aug 13, 2025
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
Looks good to me just on question on iterating through the main monitor loop
fusmanii
previously approved these changes
Aug 13, 2025
bmzig
reviewed
Aug 13, 2025
bmzig
reviewed
Aug 13, 2025
dijanin-brat
dismissed stale reviews from nicholaspai and fusmanii
via
e03ad3c
bmzig
previously approved these changes
Aug 14, 2025
bmzig
approved these changes
Aug 14, 2025
fusmanii
approved these changes
Aug 14, 2025
sameersubudhi
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Aug 18, 2025
* feat: Close PDAs for fills from our relayer * Log invalidFills without deposit * Check if PDA is already closed and enable SVM addresses to be monitored * lint fix * Use one array of Addresses for both EVM and SVM Addresses for monitored relayers * Fix MonitorClientHelper * Remove unused interface * Add simulate flag to closePDAs bot * Lint fix * Bump SDK * Lint fix * Exit early if monitoredAddress is not EVM * Log invalidFills only if there are any * Remove unnecessary if statement * Remove unused invalidFills reporting for closing PDAs * Remove unnecessary comment * Lint fix * reportRelayerBalances fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close PDAs for Fills made by our relayers.