Conversation
Deploy this at the beginning of the test run and reuse it throughout the test. This is basic infrastructre; it doesn't need to be redpeloyed repeatedly throughout the test.
pxrl
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a30921005
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let fixture: UmaEcosystem; | ||
|
|
||
| before(async function () { |
There was a problem hiding this comment.
Deploying timer once at module scope makes all HubPool instances created via getUmaFixture() share the same mutable clock. Several suites using setupDataworker/deployAndConfigureHubPool call hubPool.setCurrentTime(...), so advancing time in one test now carries into later tests and changes liveness/challenge-time behavior based on execution order. This introduces cross-test state leakage and can make tests flaky or mask timing regressions; the UMA ecosystem should stay per-test (or the timer should be reset) to preserve isolation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Codex Review: Didn't find any major issues. 👍
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Deploy this at the beginning of the test run and reuse it throughout the
test. This is basic infrastructre; it doesn't need to be redeployed
repeatedly throughout the test.