chore(deps): Remove axios, use SDK FetchUtils#3142
chore(deps): Remove axios, use SDK FetchUtils#3142nicholaspai wants to merge 9 commits intomasterfrom
Conversation
Replace all axios.get/post calls with fetchWithTimeout/postWithTimeout from @across-protocol/sdk utils. This removes a direct dependency and standardizes HTTP requests on the native fetch-based SDK utilities. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicholaspai
requested review from
bmzig,
dohaki,
mrice32 and
pxrl
as code owners
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1980945cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…dency Import from ../utils/SDKUtils instead of the ../utils barrel in AcrossApiBaseClient to prevent a circular dependency chain through the clients index. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
axiosdependency frompackage.jsonaxios.get/axios.postcalls across 10 files withfetchWithTimeout/postWithTimeoutfrom@across-protocol/sdkutils (nativefetch-based)fetchWithTimeout,postWithTimeout,FetchHeaders, andFetchQueryParamsfromSDKUtils.tsaxios.isAxiosError()checks withError.messagepattern matching (e.g.,includes("HTTP 404"))RawAxiosRequestHeaderstype withFetchHeadersfrom SDKFiles changed
src/utils/SDKUtils.tssrc/utils/OFTUtils.tsaxios.get→fetchWithTimeoutsrc/utils/CCTPUtils.tsaxios.get→fetchWithTimeoutsrc/utils/BridgeUtils.tsaxios.get/post→fetchWithTimeout/postWithTimeout,RawAxiosRequestHeaders→FetchHeaderssrc/clients/AcrossApiBaseClient.tsaxios.get→fetchWithTimeout,AxiosError→Errorsrc/clients/AcrossAPIClient.tsaxios()→fetchWithTimeoutsrc/refiller/Refiller.tsaxios.get+ 2×axios.post→ SDK utilssrc/finalizer/utils/scroll.tsaxios.get→fetchWithTimeoutsrc/finalizer/utils/helios.tsaxios.get/post/isAxiosError→ SDK utilsscripts/simulateFill.tsaxios.post/isAxiosError→postWithTimeoutscripts/fetchInventoryConfig.tsaxios.get/isAxiosError→fetchWithTimeoutTest plan
yarn buildcompiles successfully🤖 Generated with Claude Code