fix(finalizer): Fix Helios 404 detection broken by axios removal#3171
Merged
nicholaspai merged 3 commits intomasterfrom Apr 7, 2026
Merged
fix(finalizer): Fix Helios 404 detection broken by axios removal#3171nicholaspai merged 3 commits intomasterfrom
nicholaspai merged 3 commits intomasterfrom
Conversation
The SDK's fetchWithTimeout uses the JSON body's `error` field as the error message when present, so a 404 from the ZK API surfaces as e.g. "Proof request <id> not found" rather than "HTTP 404". Match on "not found" to restore correct behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicholaspai
requested review from
bmzig,
dohaki,
mrice32 and
pxrl
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8c2e29479
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pxrl
reviewed
Apr 7, 2026
2 tasks
Member
Author
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pxrl
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchWithTimeoutuses the JSON body'serrorfield as the error message when present. A 404 from the ZK API surfaces as e.g."Proof request <id> not found"rather than"HTTP 404", so theincludes("HTTP 404")check introduced in chore(deps): Remove axios, use SDK FetchUtils #3142 never matches."not found"which covers the actual API error message.Test plan
🤖 Generated with Claude Code