feat: Add postWithTimeout to FetchUtils#1373
Merged
nicholaspai merged 5 commits intomasterfrom Apr 2, 2026
Merged
Conversation
Extract shared fetch logic into a private baseFetch helper that both fetchWithTimeout (GET) and the new postWithTimeout (POST) delegate to. postWithTimeout defaults Content-Type to application/json, overridable via headers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55ff8050ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Check for an existing content-type header (case-insensitive) before injecting the default, preventing duplicate header values when callers use lowercase "content-type". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This makes header deduplication reliable regardless of caller casing, and removes the now-redundant case-insensitive check in postWithTimeout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pxrl
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baseFetchhelperfetchWithTimeoutnow delegates tobaseFetchwithmethod: "GET"— no signature changes, fully backwards compatiblepostWithTimeoutexport that sends POST requests with a JSON body, defaultingContent-Typetoapplication/json(overridable viaheaders)Test plan
fetchWithTimeoutcallers continue to work unchangedpostWithTimeoutwith a JSON bodypostWithTimeoutwith customContent-Typeheader overridepostWithTimeoutwith query params alongside body🤖 Generated with Claude Code