Skip to content

fix: fix release action#226

Merged
melisaguevara merged 2 commits intomasterfrom
mguevara/fix-release-action
Jun 10, 2025
Merged

fix: fix release action#226
melisaguevara merged 2 commits intomasterfrom
mguevara/fix-release-action

Conversation

@melisaguevara
Copy link
Copy Markdown
Contributor

@melisaguevara melisaguevara commented Jun 9, 2025

Building step was failing when we executed the release github action.
The issue seems to be that we were using an older version of pnpm (8.15.9 instead of 9.15.2) and that was causing the lockfile to be ignored as shown in the logs:
Screenshot 2025-06-09 at 4 56 13 PM

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 9, 2025

⚠️ No Changeset found

Latest commit: b57977d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
toolkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2025 7:53pm

@melisaguevara melisaguevara marked this pull request as ready for review June 9, 2025 20:00
@melisaguevara melisaguevara changed the title I'm testing stuff fix: release action Jun 9, 2025
@melisaguevara melisaguevara changed the title fix: release action fix: fix release action Jun 9, 2025
Copy link
Copy Markdown
Collaborator

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@melisaguevara melisaguevara merged commit 45191c7 into master Jun 10, 2025
3 of 4 checks passed
@melisaguevara melisaguevara deleted the mguevara/fix-release-action branch June 10, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants