feat(chart): add database name configuration#665
Open
millin wants to merge 1 commit intoacryldata:masterfrom
Open
feat(chart): add database name configuration#665millin wants to merge 1 commit intoacryldata:masterfrom
millin wants to merge 1 commit intoacryldata:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows configuring the database name through Helm values. Previously, the database name was hardcoded in the templates.
Checklist
Note
Low Risk
Small Helm chart change that only parameterizes the database name used by setup jobs; low risk aside from potential misconfiguration leading to jobs targeting the wrong DB.
Overview
Adds a new Helm value
global.sql.datasource.database(defaultdatahub) and wires it into the MySQL and PostgreSQL setup job templates soDATAHUB_DB_NAMEis no longer hardcoded.Updates
values.schema.json,values.yaml, and the chartREADME.mdvalues table to document and validate the new database-name setting.Written by Cursor Bugbot for commit 4454693. This will update automatically on new commits. Configure here.