Skip to content

Fix: Remove join fan-out bug in agg_monthly_loans #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmiller-dh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Remove join fan-out bug in agg_monthly_loans #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions models/marts/agg_monthly_loans.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ combined as (
select
coalesce(orig.month_start, pay.month_start) as month,
orig.loan_type_name,
loans.customer_id,
coalesce(orig.loans_originated, 0) as new_loans,
coalesce(orig.total_amount_originated, 0) as amount_originated,
coalesce(orig.avg_loan_amount, 0) as avg_loan_size,
Expand All @@ -45,8 +44,6 @@ combined as (
from monthly_originations orig
full outer join monthly_payments pay
on orig.month_start = pay.month_start
left join loans
on orig.loan_type_name = loans.loan_type_name
)

select * from combined
Expand Down