Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New manual rule: Correct captions #2301

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

kengdoj
Copy link
Collaborator

@kengdoj kengdoj commented Feb 7, 2025

New manual rule for correct captions:

  • Modify Video element auditory content [f51b46] to only check for captions not evaluate caption quality
  • Failed Ex 2 in Video element auditory content has captions now passes because this rule does not evaluate caption quality

Need for Call for Review:

This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@kengdoj kengdoj marked this pull request as draft February 7, 2025 16:50
@kengdoj kengdoj self-assigned this Feb 7, 2025
@kengdoj kengdoj marked this pull request as ready for review February 7, 2025 17:30

A video element with an explicitly associated text on the same page that describes the audio in the video.
A video element with an explicitly associated text on the same page that describes the audio in the video but no captions.

```html
<p id="text">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 137 there is a problem that this PR didn't create, but I noticed it while reviewing: it says ariadescribedby="text". That's missing a hyphen. It should be: aria-describedby="text"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected. Thanks!

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 60c6b06
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/67b748d165511d0008d996fa
😎 Deploy Preview https://deploy-preview-2301--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants