Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create input-aspects-to-accessibility-support.json #2302

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

carlosapaduarte
Copy link
Member

Create input-aspects-to-accessibility-support.json needed to support the automation of generating the accessibility support section based on input aspects of the rules

Need for Call for Review:
This will not require a Call for Review: change to website/test code (not rule)

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@@ -0,0 +1,3 @@
{
"accessibility tree": "`aria-busy` exists but, currently, is not widely supported, so the rule ignores it."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"accessibility tree": "`aria-busy` exists but, currently, is not widely supported, so the rule ignores it."
"accessibility tree": "`aria-busy` is currently not widely supported and so cannot be relied on for this rule."

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Wilco's suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants