-
Notifications
You must be signed in to change notification settings - Fork 78
Update form-field-label-descriptive-cc0f0a.md #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update form-field-label-descriptive-cc0f0a.md #2345
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
||
Each test target has a label, and the label is descriptive. | ||
|
||
## Expectation 2 | ||
|
||
Each test target, together with its [visual context][], describes the purpose of the associated element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each test target, together with its [visual context][], describes the purpose of the associated element. | |
Each test target's label, together with its [visual context][], describes the purpose of the associated element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in today's meeting, I'll be removing this and refactoring expectation 1 into two separate expectations instead. We will still need to come up with a better definition for label, however.
Addresses the following survey action items in regards to rule cc0f0a - Form field label is descriptive:
The remaining action item reads "Visual context definition is somewhat ambiguous and vague and needs to be improved." @WilcoFiers, are you able to speak more on the ambiguity we should improve on?
I believe this was previously assigned to @colabottles, and I'm happy to collaborate or cede these changes to you if you're farther along here!
Finally, as this is my first PR or direct change to the repo, please let me know if there is anything I've missed process-wise. I've chosen a 1-week review, but I can change that if changing the visual context definition increases the complexity.
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve