Skip to content

Conversation

sage-putnam
Copy link
Collaborator

Addresses the following survey action items in regards to rule cc0f0a - Form field label is descriptive:

  • "Remove the first assumption. It's not needed for the rule to be valid"
  • Applicability should not include programmatic label. Rule should have an expectation that there is a label, and a second that the label is descriptive

The remaining action item reads "Visual context definition is somewhat ambiguous and vague and needs to be improved." @WilcoFiers, are you able to speak more on the ambiguity we should improve on?

I believe this was previously assigned to @colabottles, and I'm happy to collaborate or cede these changes to you if you're farther along here!

Finally, as this is my first PR or direct change to the repo, please let me know if there is anything I've missed process-wise. I've chosen a 1-week review, but I can change that if changing the visual context definition increases the complexity.

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@sage-putnam sage-putnam self-assigned this Aug 14, 2025
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 9d8dc9e
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/68b070cfa439b50008452448
😎 Deploy Preview https://deploy-preview-2345--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2025

CLA assistant check
All committers have signed the CLA.

@sage-putnam sage-putnam added Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already labels Aug 14, 2025
@sage-putnam sage-putnam marked this pull request as ready for review August 28, 2025 14:39

Each test target has a label, and the label is descriptive.

## Expectation 2

Each test target, together with its [visual context][], describes the purpose of the associated element.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Each test target, together with its [visual context][], describes the purpose of the associated element.
Each test target's label, together with its [visual context][], describes the purpose of the associated element.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in today's meeting, I'll be removing this and refactoring expectation 1 into two separate expectations instead. We will still need to come up with a better definition for label, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewers wanted Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"labels are intended for sighted users" is a confusing statement [cc0f0a]
4 participants