Skip to content

Conversation

daniel-montalvo
Copy link
Collaborator

@daniel-montalvo daniel-montalvo commented Sep 1, 2025

<< Describe the changes >>

Fix broken glossary link

Closes issue(s):

  • closes #XXX (ADD ISSUE NUMBER HERE)

Need for Call for Review:
<< choose one of the following and remove the rest >>
<< check Process Document on Call for Review >>
This will not require a Call for Review << choose reason(s): editorial changes (including to the applicability, expectation or examples section), changes to assumptions, background, accessibility support, change to website/test code (not rule), other (explain). >>

Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link

netlify bot commented Sep 1, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit ad89bb8
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/68b5b2900f8fd00008f59b10
😎 Deploy Preview https://deploy-preview-2349--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daniel-montalvo daniel-montalvo added the Editorial For editorial changes that does not change the meaning of a rule or Glossary term label Sep 1, 2025
@daniel-montalvo daniel-montalvo self-assigned this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial For editorial changes that does not change the meaning of a rule or Glossary term
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant