Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error during initial release script run #994

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

ncalteen
Copy link
Collaborator

Closes #937

When the release script runs for the first time (no version tags exist in the repository yet), an error will occur that causes the script to exit early. This was caused by the script attempting to compare the latest tag with the new tag, but since there was no latest tag, the comparison failed.

This PR fixes this case by checking the latest tag before attempting to compare them.

@ncalteen ncalteen self-assigned this Jan 10, 2025
@ncalteen ncalteen requested a review from a team as a code owner January 10, 2025 15:30
Copy link
Contributor

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ncalteen ncalteen merged commit c065465 into main Jan 10, 2025
22 checks passed
@ncalteen ncalteen deleted the ncalteen/release branch January 10, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release script fails if no latest release tag exists
2 participants