feat: 增加对于会话数据源连接数的限制 关闭某个用户的数据源接口 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * 记录 userId + dataSourceId 的会话数 Key格式: userId:dataSourceId | ||
| */ | ||
| private Map<String, AtomicInteger> userId2DataSourceId2SessionCountMap = new ConcurrentHashMap<>(); |
Collaborator
There was a problem hiding this comment.
这里记录的为什么是会话数，预期是连接数？
Author
There was a problem hiding this comment.
这里暂时是会话层面的连接，再目前一个会话对应一个连接的情况下是正确的。
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectSessionService.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Connection count manager for tracking database connections by url+username | ||
| * | ||
| * @author yh263208 |
| log.info("Incremented connection count, key={}", this.connectionKey); | ||
| Connection connection = newConnectionFromDriver(getUsername(), getPassword()); | ||
| // Generate connection key and check/increment connection count | ||
| this.connectionKey = ConnectionCountManager.generateKey(getUrl(), getUsername()); |
Collaborator
There was a problem hiding this comment.
这里的url指的是啥，username是数据库连接用户名称吗
Author
There was a problem hiding this comment.
url是数据库连接串，username是数据库连接用户名
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actiontech/dms#542