Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bancolombia icon #1259

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add bancolombia icon #1259

wants to merge 8 commits into from

Conversation

tamfrazzetta
Copy link
Contributor

@tamfrazzetta tamfrazzetta commented Dec 3, 2024 •
edited
Loading

Why are you adding this icons?

I'm adding/updating this icon(s) because ..

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

image

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: white; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<!-- Change background color if needed to showcase your icon better -->
<style> body { background: white; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg width="38" height="24" viewBox="0 0 38 24" fill="none" xmlns="http://www.w3.org/2000/svg" aria-labelledby="pi-bancolombia"><title id="pi-bancolombia">Bancolombia</title><rect width="38" height="24" rx="3" fill="#fff"/><rect x=".5" y=".5" width="37" height="23" rx="2.5" stroke="#000" stroke-opacity=".07"/><path fill-rule="evenodd" clip-rule="evenodd" d="M24.168 16.105a64.825 64.825 0 00-6.514 1.959c-.306.115-.638-.035-.718-.329-.173-.626-.326-1.107-.497-1.73a.547.547 0 01.354-.646 57.663 57.663 0 016.516-1.782c.244-.05.5.13.588.405.18.559.335 1.009.51 1.57.078.254-.027.502-.239.553zm-11.085-1.196c-.131-.673-.263-1.178-.391-1.85a.636.636 0 01.332-.673c3.27-1.437 6.72-2.307 10.263-2.755.234-.03.47.142.557.4.187.553.346 1 .527 1.556.088.268-.028.53-.257.567-3.603.572-7.115 1.535-10.437 3.046-.267.13-.538-.003-.594-.29zm1.592-7.65c2.191-.63 4.379-1.04 6.641-1.316a.565.565 0 01.578.375c.21.573.382 1.03.587 1.606.097.272-.047.545-.313.581-2.316.34-4.56.809-6.8 1.492-.273.091-.54-.047-.61-.312-.163-.629-.31-1.112-.47-1.739a.587.587 0 01.387-.687zM19 2C13.477 2 9 6.477 9 12s4.477 10 10 10 10-4.477 10-10S24.523 2 19 2z" fill="#2C2A29" stroke="#000" stroke-opacity=".01" stroke-width=".1"/></svg>


<br>
<!-- TODO: insert your icon here -->
<svg width="38" height="24" viewBox="0 0 38 24" fill="none" xmlns="http://www.w3.org/2000/svg" aria-labelledby="pi-bancolombia"><title id="pi-bancolombia">Bancolombia</title><rect width="38" height="24" rx="3" fill="#fff"/><rect x=".5" y=".5" width="37" height="23" rx="2.5" stroke="#000" stroke-opacity=".07"/><path fill-rule="evenodd" clip-rule="evenodd" d="M24.168 16.105a64.825 64.825 0 00-6.514 1.959c-.306.115-.638-.035-.718-.329-.173-.626-.326-1.107-.497-1.73a.547.547 0 01.354-.646 57.663 57.663 0 016.516-1.782c.244-.05.5.13.588.405.18.559.335 1.009.51 1.57.078.254-.027.502-.239.553zm-11.085-1.196c-.131-.673-.263-1.178-.391-1.85a.636.636 0 01.332-.673c3.27-1.437 6.72-2.307 10.263-2.755.234-.03.47.142.557.4.187.553.346 1 .527 1.556.088.268-.028.53-.257.567-3.603.572-7.115 1.535-10.437 3.046-.267.13-.538-.003-.594-.29zm1.592-7.65c2.191-.63 4.379-1.04 6.641-1.316a.565.565 0 01.578.375c.21.573.382 1.03.587 1.606.097.272-.047.545-.313.581-2.316.34-4.56.809-6.8 1.492-.273.091-.54-.047-.61-.312-.163-.629-.31-1.112-.47-1.739a.587.587 0 01.387-.687zM19 2C13.477 2 9 6.477 9 12s4.477 10 10 10 10-4.477 10-10S24.523 2 19 2z" fill="#2C2A29" stroke="#000" stroke-opacity=".01" stroke-width=".1"/></svg>
</br
</br

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

Lydia-shan-git
Lydia-shan-git reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@Lydia-shan-git Lydia-shan-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure your border is 1 px thick and follows a radius of 2px as in the guidelines

Lydia-shan-git
Lydia-shan-git requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@Lydia-shan-git Lydia-shan-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure your border is 1 px thick and follows a radius of 2px as in the guidelines

@dannye0231
Copy link
Contributor

@tamfrazzetta can you please re-base this PR?

@dannye0231
Copy link
Contributor

@tamfrazzetta can you please fix the following issue with your SVG file?

Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:93]:
{:message=>"The 'bancolombia' SVG file should have a 'role' attribute on the root tag"}

@tamfrazzetta
Copy link
Contributor Author

@tamfrazzetta can you please fix the following issue with your SVG file?

Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:93]: {:message=>"The 'bancolombia' SVG file should have a 'role' attribute on the root tag"}

Done and rebased 👌

@dannye0231
Copy link
Contributor

@Lydia-shan-git are you able to review again, as changes have been made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lydia-shan-git Lydia-shan-git Awaiting requested review from Lydia-shan-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamfrazzetta @dannye0231 @Lydia-shan-git