Add a new icon for zaver #1272

divyach0209 · 2025-01-02T11:20:35Z

Why are you adding this icons?

I'm adding/updating this icon(s) because our payment gateway offer a new payment method called Zaver.

Help us identify yourself

I'm working/collaborating with the brand directly and they have provided the icons.
I'm associated with the brand and I've read all the brand icon’s guidelines.
I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

All icons have a corresponding entry in db/payment_icons.yml
I have followed the icon guidelines detailed in the CONTRIBUTING.md file
I have optimized the icon with SVGO
I am confident that all icons are clear and easy to read/understand
I have provided a link to the brand icon’s brand guidelines whenever possible.
I have attached a screenshot comparison with the example icon provided in guidelines
I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<YOUR SVG CODE>

<br>
<!-- TODO: insert your icon here -->
<YOUR SVG CODE>
</br

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

divyach0209 · 2025-01-24T14:41:51Z

Hello @Lydia-shan-git
could you please help to review this as soon as possible as due to a customer requirement we need to use it on our shopify app.

divyach0209 · 2025-01-27T12:41:46Z

Hi @dannye0231
Hope you are doing well. Could you please help me out to get this PR reviewed as soon as possible as whole feature is build and just waiting for this PR to be rollout to make the release to have the included shopify icon or method visible.

dannye0231 · 2025-01-27T18:43:33Z

Hi @divyach0209 , we are aiming for Feb 5th to get these PRs merged.

Can you please re-base as well?

divyach0209 · 2025-01-28T05:22:21Z

sure thanks for the update @dannye0231 :)

Lydia-shan-git

Please make sure your border is 1 px thick and follows the radius of 2 px as shown in the guidelines (https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md#appearance)

divyach0209 · 2025-01-29T07:10:30Z

Hi @Lydia-shan-git
Thanks for taking this into consideration. I have updated the icon with specific border and radius as per the guidelines and have rebased with latest changes too @dannye0231.

So could you please help to re-review the same ? and please let me know if anything required from my side.

Lydia-shan-git

Thank you for the changes, just make sure that your logo does not overlap with the border. It should stay within the border

divyach0209 · 2025-02-05T03:57:41Z

Hi @Lydia-shan-git
Thank you for responding back. I have fixed the border overlapping too here could you please re-review the same and help to process this further.

dannye0231 · 2025-02-05T18:58:29Z

@divyach0209 are you able to check your SVG for the following issue?

Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:74]:
{:message=>"The 'zaver' SVG file should have a <title> tag as first child of the root tag"}.
Expected: "title"
Actual: "rect"

divyach0209 · 2025-02-06T05:43:41Z

Hi @dannye0231
Have fixed the title placement and rebase with upstream too for resolving conflicts. Could you please help re-review and proceed now. Will be really helpful if we could be able to merge this week only.

divyach0209 · 2025-02-11T04:58:04Z

Hi @dannye0231 @Lydia-shan-git
Hope you are doing well!
Could you please help me to re-review and proceed on this PR as it's halting production deployment of a payment method included with icon which is done.

dannye0231 · 2025-02-11T18:07:36Z

Hi @divyach0209 , it looks good from my side now. We'll need our UX team to approve before it can get merged. Our next merge window (once approved) will be in early March.

divyach0209 · 2025-02-17T06:18:31Z

Hi @dannye0231
Could you please help me to atleast get an approval on this so that if anything needs to be update then I can be on top of that and it won't get delay anymore.

divyach0209 · 2025-03-03T09:10:07Z

Hi @Lydia-shan-git @dannye0231
Can we please get an update on this ? We are waiting to launch the payment method and stuck with the icon. Could you please help out here ?

dannye0231 · 2025-03-03T14:07:11Z

Hi @divyach0209 , we're aiming to have everything ready for Wednesdays merge run.

divyach0209 · 2025-03-03T14:24:26Z

Hi @dannye0231
Thank you so much for getting back to me. As right now it shows no conflicts with base branch. So if you think anything needs to be fix on prior please do let me know so I can make the changes ready before wednesday :)

divyach0209 · 2025-03-10T04:43:58Z

Hi @dannye0231 @Lydia-shan-git
Is there any updates on the same ? Could you please help me out on status when we can expect this merge or if there is anything needs to be fix could you please help me to share before your merge window would be really great.

dannye0231 · 2025-03-10T19:26:18Z

@divyach0209 we are aiming for this Wednesday to start the merge. I am just working on getting the last approval needed

divyach0209 · 2025-03-12T13:49:32Z

Hey @dannye0231
Could you please help out us to get an update here ?

renjith-mondido · 2025-03-21T07:38:58Z

Hi ,

We will be really grateful, if you can inform us the plan, so we can inform our integration parters about the time plan,

dannye0231 · 2025-03-21T17:37:19Z

Hi @renjith-mondido , we ran into some delays on our end and will most likely be processing your PR in the first week of April.

dannye0231 · 2025-03-31T17:21:56Z

@divyach0209 can you please check the following:

Visible Border: ❌ (The outer rectangle has a stroke color of "0000" which is invalid; it should be a hex color like #000 or transparent if no border is desired)
Border Color: ❌ (The stroke color should be specified correctly)

Correct the stroke color of the outer rectangle to a valid hex color (e.g., #000 for black)
Ensure the border width is set to 1px

divyach0209 · 2025-04-01T07:45:28Z

Hi @dannye0231
Have made the changes as required could you please have a look on.

cc : @renjith-mondido

dannye0231 · 2025-04-01T13:39:02Z

@divyach0209 can you please check the following based on our requirements?

Opacity Requirement:

Opacity Definition: Check if the SVG has an opacity attribute set for any elements. If not, ensure that the design does not require any transparency.
Status: ❌ (No opacity set; review contribution guidelines for specific requirements.)

divyach0209 · 2025-04-02T04:20:33Z

Hi @dannye0231
I have checked that the SVG does not use any transparency effects. All elements have solid colors, and no opacity settings are required for the intended design. Let me know if a specific opacity level is mandated by the guidelines but for now never used any opacity element and after cross checking guidelines document never found that opacity is required too.
Please let me know if there is any need of the same.

Also it would be really great if we got this merged on this time as we were waiting for the same since January.

dannye0231 · 2025-04-02T13:41:16Z

Please refer to our contribution guide regarding the opacity requirement:

Whenever possible, the border should be black (hex color #000) with a 7% opacity (0.07).

divyach0209 · 2025-04-03T05:48:01Z

Hi @dannye0231
Thanks for reply back. Added opacity and colour accordingly could you please re-review the same and let me know if anything else required.

dannye0231

SVG Code Review

Root Tag Attributes:
xmlns: ✅ Correctly included (xmlns="http://www.w3.org/2000/svg").
role: ✅ Correctly set (role="img").
viewBox: ✅ Present and correct (viewBox="0 0 38 24").
width and height: ✅ Present and correct (width="38" and height="24").
aria-labelledby: ✅ Correctly references the <title> element (aria-labelledby="pi-zaver").

Nested <title> Tag:
id: ✅ Correctly set to id="pi-zaver".

Inner text: ✅ Appropriately describes the icon (<title>Zaver</title>).

Standard SVG Structure:
✅ The SVG follows a proper structure with nested elements.

Vector Graphics Requirement:
✅ The SVG consists of vector graphics elements only, using and elements.

Embedded Fonts and Bitmaps:
✅ No embedded fonts or bitmap images are present.

ID Attributes:
✅ No conflicting ID attributes; all IDs follow the pi- naming convention.

Inline Styles:
✅ No <style> tags are present; styles are applied inline.

Base64 Encoded Images:
✅ No base64-encoded images are present, which is acceptable.

Class Attributes:
✅ No class attributes are present in the SVG.

Logos and Backgrounds:
✅ The SVG contains a background rectangle with a white fill and a black stroke with low opacity.

Clarity and Readability:
✅ The icon appears clear and recognizable.

Accessibility:
✅ The <title> element enhances accessibility for screen readers.

Structure:
✅ The SVG structure is organized and properly nested.

Metadata:
✅ There are no additional elements, but this is not mandatory.

divyach0209 · 2025-04-03T14:02:13Z

Hi @dannye0231
Thank you so much for merging the PR :)
I tried to allow the same method on our staging app but getting issue from shopify that :
╭─ error ──────────────────────────────────────────────────────────────────────╮
│ │
│ Version couldn't be created. │
│ │
│ payment-gateway │
│ │
│ Validation errors │
│ • supported_payment_methods: Following payment methods not permitted: │
│ ["zaver"] │
│ │
╰──────────────────────────────────────────────────────────────────────────────╯

So is it like we have to wait for the deployment now ?

It would be really great if you could help us with the same.

dannye0231 · 2025-04-03T14:42:46Z

The merge process just started, and it takes around 1 week+ to complete. I'd recommend checking back mid next week to see if all of the repos have received your change/update.

…

On Thu, Apr 3, 2025 at 10:02 AM divyach0209 ***@***.***> wrote: Hi @dannye0231 <https://github.com/dannye0231> Thank you so much for merging the PR :) I tried to allow the same method on our staging app but getting issue from shopify that : ╭─ error ──────────────────────────────────────────────────────────────────────╮ │ │ │ Version couldn't be created. │ │ │ │ payment-gateway │ │ │ │ Validation errors │ │ • supported_payment_methods: Following payment methods not permitted: │ │ ["zaver"] │ │ │ ╰──────────────────────────────────────────────────────────────────────────────╯ So is it like we have to wait for the deployment now ? It would be really great if you could help us with the same. — Reply to this email directly, view it on GitHub <#1272 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BCIWTQS7LXWBJHZF7Y2YTRT2XU5PXAVCNFSM6AAAAABUPZDXAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZVHEYDAMBUGU> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: divyach0209]*divyach0209* left a comment (activemerchant/payment_icons#1272) <#1272 (comment)> Hi @dannye0231 <https://github.com/dannye0231> Thank you so much for merging the PR :) I tried to allow the same method on our staging app but getting issue from shopify that : ╭─ error ──────────────────────────────────────────────────────────────────────╮ │ │ │ Version couldn't be created. │ │ │ │ payment-gateway │ │ │ │ Validation errors │ │ • supported_payment_methods: Following payment methods not permitted: │ │ ["zaver"] │ │ │ ╰──────────────────────────────────────────────────────────────────────────────╯ So is it like we have to wait for the deployment now ? It would be really great if you could help us with the same. — Reply to this email directly, view it on GitHub <#1272 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BCIWTQS7LXWBJHZF7Y2YTRT2XU5PXAVCNFSM6AAAAABUPZDXAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZVHEYDAMBUGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

bhavesha16 approved these changes Jan 6, 2025

View reviewed changes

dannye0231 requested a review from Lydia-shan-git January 8, 2025 15:14

dannye0231 added the Changes Requested label Jan 27, 2025

Lydia-shan-git requested changes Jan 28, 2025

View reviewed changes

divyach0209 force-pushed the zaver_icon branch from a78fc17 to 98407aa Compare January 29, 2025 07:06

divyach0209 requested a review from Lydia-shan-git January 29, 2025 07:10

dannye0231 removed the Changes Requested label Jan 29, 2025

Lydia-shan-git requested changes Feb 3, 2025

View reviewed changes

dannye0231 added the Changes Requested label Feb 3, 2025

divyach0209 requested a review from Lydia-shan-git February 5, 2025 03:56

divyach0209 force-pushed the zaver_icon branch from e7e81d6 to ca3954f Compare February 6, 2025 05:41

dannye0231 removed the Changes Requested label Feb 11, 2025

dannye0231 requested a review from johnchanshopify March 10, 2025 19:25

dannye0231 added the Changes Requested label Mar 31, 2025

divyach0209 added 6 commits April 3, 2025 11:13

Add a new icon for zaver

5481f0a

Updated border and radius

dbf0a8a

Fixed border overlapping issue with icon

33182dc

Fixed title placement

96831d4

Fixed border colour of icon

0738815

Added opacity as per requirement

e90ee8c

divyach0209 force-pushed the zaver_icon branch from 49fb80d to e90ee8c Compare April 3, 2025 05:46

dannye0231 added Ready to deploy and removed Changes Requested labels Apr 3, 2025

dannye0231 self-requested a review April 3, 2025 13:29

dannye0231 approved these changes Apr 3, 2025

View reviewed changes

dannye0231 merged commit 0a80d50 into activemerchant:master Apr 3, 2025
8 checks passed

shopify-shipit-activemerchant bot temporarily deployed to rubygems April 7, 2025 18:19 Inactive

Add a new icon for zaver #1272

Add a new icon for zaver #1272

Uh oh!

Conversation

divyach0209 commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are you adding this icons?

Help us identify yourself

Checklist to add new icons

Attach a screenshot of the icon along side the example Visa icon

Tips how to create a screenshot

If the icons are intended for use by Shopify, please provide the following info:

Uh oh!

divyach0209 commented Jan 24, 2025

Uh oh!

divyach0209 commented Jan 27, 2025

Uh oh!

dannye0231 commented Jan 27, 2025

Uh oh!

divyach0209 commented Jan 28, 2025

Uh oh!

Lydia-shan-git left a comment

Choose a reason for hiding this comment

Uh oh!

divyach0209 commented Jan 29, 2025

Uh oh!

Lydia-shan-git left a comment

Choose a reason for hiding this comment

Uh oh!

divyach0209 commented Feb 5, 2025

Uh oh!

dannye0231 commented Feb 5, 2025

Uh oh!

divyach0209 commented Feb 6, 2025

Uh oh!

divyach0209 commented Feb 11, 2025

Uh oh!

dannye0231 commented Feb 11, 2025

Uh oh!

divyach0209 commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

divyach0209 commented Mar 3, 2025

Uh oh!

dannye0231 commented Mar 3, 2025

Uh oh!

divyach0209 commented Mar 3, 2025

Uh oh!

divyach0209 commented Mar 10, 2025

Uh oh!

dannye0231 commented Mar 10, 2025

Uh oh!

divyach0209 commented Mar 12, 2025

Uh oh!

renjith-mondido commented Mar 21, 2025

Uh oh!

dannye0231 commented Mar 21, 2025

Uh oh!

dannye0231 commented Mar 31, 2025

Uh oh!

divyach0209 commented Apr 1, 2025

Uh oh!

dannye0231 commented Apr 1, 2025

Uh oh!

divyach0209 commented Apr 2, 2025

Uh oh!

dannye0231 commented Apr 2, 2025

Uh oh!

divyach0209 commented Apr 3, 2025

Uh oh!

dannye0231 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

divyach0209 commented Apr 3, 2025

Uh oh!

dannye0231 commented Apr 3, 2025 via email

Uh oh!

Uh oh!

divyach0209 commented Jan 2, 2025 •

edited

Loading

divyach0209 commented Feb 17, 2025 •

edited

Loading