Skip to content

do not remove the uds socket on pause #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

do not remove the uds socket on pause #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ab4144
do not remove the uds socket on pause
hommeabeil Feb 3, 2022
60e1ebb
fmt
hommeabeil Feb 3, 2022
89c9d94
revert the delete
hommeabeil Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actix-server/examples/tcp-echo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ async fn run() -> io::Result<()> {
let count = Arc::new(AtomicUsize::new(0));

let addr = ("127.0.0.1", 8080);
info!("starting server on port: {}", &addr.0);
info!("starting server on: {}:{}", &addr.0, &addr.1);

// Bind socket address and start worker(s). By default, the server uses the number of physical
// CPU cores as the worker count. For this reason, the closure passed to bind needs to return
Expand Down
12 changes: 1 addition & 11 deletions actix-server/src/socket.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,7 @@ impl Source for MioListener {
match *self {
MioListener::Tcp(ref mut lst) => lst.deregister(registry),
#[cfg(unix)]
MioListener::Uds(ref mut lst) => {
let res = lst.deregister(registry);

// cleanup file path
if let Ok(addr) = lst.local_addr() {
if let Some(path) = addr.as_pathname() {
let _ = std::fs::remove_file(path);
}
}
res
}
MioListener::Uds(ref mut lst) => lst.deregister(registry),
}
}
}
Expand Down