C-17 Whales Emily and Sorida Adagrams#37
Open
emilysaeli wants to merge 8 commits intoada-c17:masterfrom
Open
Conversation
jericahuang
reviewed
Apr 8, 2022
jericahuang
left a comment
jericahuang
left a comment
There was a problem hiding this comment.
Great work on this project, Emily and Sorida! The code you wrote together both passed all the tests and met the learning goals. I also made note of great highlights I saw. You both have earned a 🟢 on Adagrams!
| pass | ||
| random_letter = [] | ||
| is_valid = True | ||
| while is_valid: |
There was a problem hiding this comment.
Great while loop implementation with a boolean flag!
| if letter in letter_bank: | ||
| continue | ||
| else: | ||
| return False |
There was a problem hiding this comment.
Nice way to short circuit this function!
| if len(highest_word) == 10: | ||
| continue | ||
| elif len(word) == 10 or len(word) < len(highest_word): | ||
| highest_word = word |
There was a problem hiding this comment.
Nice implementation of the tiebeaker logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.